Add administrative area dropdown for US, CA #5518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
requested review from
brnunes-stripe,
michelleb-stripe and
tillh-stripe
as code owners
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-state-dropdown
branch
from
ea5614c
to
ed69a1a
Compare
jameswoo-stripe
requested review from
ccen-stripe and
awush-stripe
as code owners
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-state-dropdown
branch
from
ed69a1a
to
0a83870
Compare
jameswoo-stripe
force-pushed
the
jameswoo/shipping-address-element-state-dropdown
branch
from
0a83870
to
48f22d9
Compare
tillh-stripe
reviewed
Sep 7, 2022
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
| * [CHANGED][5487](https://github.com/stripe/stripe-android/pull/5487) Updated Google Pay button to match new brand guidelines. | |||
| * [ADDED][5502](https://github.com/stripe/stripe-android/pull/5502) Added phone number minimum length | |||
| validation | |||
| * [ADDED][5518](https://github.com/stripe/stripe-android/pull/5518) Added state/province dropdown for US/CA countries. | |||
There was a problem hiding this comment.
Suggested change
| * [ADDED][5518](https://github.com/stripe/stripe-android/pull/5518) Added state/province dropdown for US/CA countries. | |
| * [ADDED][5518](https://github.com/stripe/stripe-android/pull/5518) Added state/province dropdown for US and Canada. |
tillh-stripe
approved these changes
Sep 7, 2022
jameswoo-stripe
deleted the
jameswoo/shipping-address-element-state-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add hard coded administrative area drop down for US and CA
Motivation
Address element
Testing
Screenshots
statedropdown.mov
Changelog