Fix deletion of saved PM #5592
Merged
Fix deletion of saved PM #5592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
tillh-stripe and
jameswoo-stripe
as code owners
brnunes-stripe
requested review from
ccen-stripe and
awush-stripe
as code owners
awush-stripe
approved these changes
Sep 22, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the user deletes a saved PM that was last used, we were keeping it as the selected item. If the user then confirms the payment without changing the selection, the payment would fail because we'd try to use the deleted PM.
Motivation
Fix bug when deleting the payment method that was last used.
Testing
Screenshots
delete.mp4