[BANKCON-5411] Expands payment_method when attaching FCSessions to PI / SI #5624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
requested review from
brnunes-stripe,
tillh-stripe,
ccen-stripe and
jameswoo-stripe
as code owners
| @@ -342,7 +342,8 @@ internal class USBankAccountFormViewModel @Inject internal constructor( | |||
| ApiRequest.Options( | |||
| apiKey = lazyPaymentConfig.get().publishableKey, | |||
| stripeAccount = lazyPaymentConfig.get().stripeAccountId | |||
| ) | |||
| ), | |||
| expandFields = emptyList() | |||
There was a problem hiding this comment.
@jameswoo-stripe we don't need the payment method to be expanded on payment sheet right?
There was a problem hiding this comment.
No, we don't need to expand the payment method 👍
jameswoo-stripe
approved these changes
Sep 27, 2022
|
Diffuse output: APKDEX |
carlosmuvi-stripe
deleted the
f/BANKCON-5411_ACH_Expand_payment_method_by_default_when_attaching_FCSessions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Integrators don't currently have a way to retrieve the financial connections account id from the output of
CollectBankAccountflow.Motivation
Feature parity with iOS and StripeJS
Testing
Changelog