Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle blank fields in ShippingInfoWidget #5701

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

brnunes-stripe
Copy link
Contributor

Summary

Treat blank fields as invalid in ShippingInfoWidget.
Previously only fully empty fields were considered invalid.

Motivation

#5690

Testing

  • Added tests
  • Modified tests
  • Manually verified

@brnunes-stripe brnunes-stripe changed the title Handle empty fields in ShippingInfoWidget Handle blank fields in ShippingInfoWidget Oct 12, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 12, 2022

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │         compressed          │         uncompressed          
          ├──────────┬──────────┬───────┼───────────┬───────────┬───────
 APK      │ old      │ new      │ diff  │ old       │ new       │ diff  
──────────┼──────────┼──────────┼───────┼───────────┼───────────┼───────
      dex │  5.2 MiB │  5.2 MiB │ +80 B │  13.5 MiB │  13.5 MiB │ -60 B 
     arsc │  1.9 MiB │  1.9 MiB │   0 B │   1.9 MiB │   1.9 MiB │   0 B 
 manifest │  4.1 KiB │  4.1 KiB │   0 B │  19.2 KiB │  19.2 KiB │   0 B 
      res │    1 MiB │    1 MiB │   0 B │   1.8 MiB │   1.8 MiB │   0 B 
   native │  2.5 MiB │  2.5 MiB │   0 B │   5.9 MiB │   5.9 MiB │   0 B 
    asset │    3 MiB │    3 MiB │   0 B │     3 MiB │     3 MiB │   0 B 
    other │ 82.5 KiB │ 82.5 KiB │   0 B │ 158.5 KiB │ 158.5 KiB │   0 B 
──────────┼──────────┼──────────┼───────┼───────────┼───────────┼───────
    total │ 13.7 MiB │ 13.7 MiB │ +80 B │  26.2 MiB │  26.2 MiB │ -60 B 

         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      2 │      2 │    0 │        │        │           
 strings │  84264 │  84264 │    0 │  69878 │  69878 │ 0 (+0 -0) 
   types │  21729 │  21729 │    0 │  19447 │  19447 │ 0 (+0 -0) 
 classes │  17424 │  17424 │    0 │  17424 │  17424 │ 0 (+0 -0) 
 methods │  93712 │  93712 │    0 │  89501 │  89501 │ 0 (+0 -0) 
  fields │ 101770 │ 101770 │    0 │ 100426 │ 100426 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  334 │  334 │  0   
 entries │ 6246 │ 6246 │  0
APK
   compressed    │  uncompressed   │                
─────────┬───────┼─────────┬───────┤                
 size    │ diff  │ size    │ diff  │ path           
─────────┼───────┼─────────┼───────┼────────────────
 2.1 MiB │ +80 B │ 5.7 MiB │ -60 B │ ∆ classes2.dex 
─────────┼───────┼─────────┼───────┼────────────────
 2.1 MiB │ +80 B │ 5.7 MiB │ -60 B │ (total)

@brnunes-stripe brnunes-stripe merged commit 886aab9 into master Oct 13, 2022
@brnunes-stripe brnunes-stripe deleted the brnunes/shipping branch October 13, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants