-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent back during payment intent confirmation #5789
Merged
tillh-stripe
merged 1 commit into
master
from
tillh/prevent-back-during-intent-confirmation
Nov 10, 2022
Merged
Prevent back during payment intent confirmation #5789
tillh-stripe
merged 1 commit into
master
from
tillh/prevent-back-during-intent-confirmation
Nov 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/prevent-back-during-intent-confirmation
branch
from
November 8, 2022 21:21
e049286
to
b2f54f4
Compare
tillh-stripe
commented
Nov 8, 2022
@@ -2,6 +2,9 @@ | |||
|
|||
## XX.XX.XX - 2022-XX-XX | |||
|
|||
### Payments | |||
* [CHANGED][5789](https://github.com/stripe/stripe-android/pull/5789) We now disable the back button while confirming intents with `PaymentLauncher` to prevent them from incorrectly being displayed as failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on the wording?
tillh-stripe
requested review from
jaynewstrom-stripe,
ccen-stripe,
awush-stripe and
jameswoo-stripe
as code owners
November 8, 2022 21:21
jaynewstrom-stripe
approved these changes
Nov 8, 2022
Diffuse output:
APK
DEX
|
tillh-stripe
deleted the
tillh/prevent-back-during-intent-confirmation
branch
November 10, 2022 16:20
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where a payment was incorrectly displayed as
failed
when pressing the back button while confirming the payment intent.We now ignore back presses in the
PaymentLauncherConfirmationActivity
.Motivation
Resolves #5771
Testing
Screenshots
N/A
Changelog
[CHANGED] We now disable the back button while confirming intents via
PaymentLauncher
to prevent them from incorrectly being displayed as failed.