-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Identity] Wait for VerificaionPage response to return when process is killed #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
DEX
|
ccen-stripe
requested review from
jaynewstrom-stripe and
jameswoo-stripe
as code owners
November 14, 2022 19:37
identity/src/main/java/com/stripe/android/identity/ui/ConfirmationScreen.kt
Show resolved
Hide resolved
Co-authored-by: Till Hellmund <110940675+tillh-stripe@users.noreply.github.com>
tillh-stripe
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When activity is killed by system, another API request is made to fetch
Resource<VerificationPage>
.The compose screens(
ConfirmationScreen
,UploadScreen
,DocSelectionScreen
) can't userequireNotNull
as the request is still pending. Refactor the compose method to draw a Loading screen when the request is pending.Motivation
Recover from process kill
Testing
Screenshots
Changelog