Eagerly finish activities if they're started with invalid args.

[jaynewstrom-stripe]

Summary

Motivation

#5876

Testing

• Added tests
• Modified tests
• Manually verified

Screenshots

Before	After
before screenshot	after screenshot

Changelog

[github-actions]

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │           uncompressed           
          ├──────────┬──────────┬────────┼───────────┬───────────┬──────────
 APK      │ old      │ new      │ diff   │ old       │ new       │ diff     
──────────┼──────────┼──────────┼────────┼───────────┼───────────┼──────────
      dex │  5.7 MiB │  5.7 MiB │ +385 B │  14.9 MiB │  14.9 MiB │ +1.2 KiB 
     arsc │    2 MiB │    2 MiB │    0 B │     2 MiB │     2 MiB │      0 B 
 manifest │  4.3 KiB │  4.3 KiB │    0 B │  20.4 KiB │  20.4 KiB │      0 B 
      res │  1.1 MiB │  1.1 MiB │    0 B │   1.8 MiB │   1.8 MiB │      0 B 
   native │  2.6 MiB │  2.6 MiB │    0 B │     6 MiB │     6 MiB │      0 B 
    asset │    3 MiB │    3 MiB │ +234 B │     3 MiB │     3 MiB │   +234 B 
    other │ 82.9 KiB │ 82.9 KiB │    0 B │ 158.3 KiB │ 158.3 KiB │      0 B 
──────────┼──────────┼──────────┼────────┼───────────┼───────────┼──────────
    total │ 14.4 MiB │ 14.4 MiB │ +619 B │  27.9 MiB │  27.9 MiB │ +1.5 KiB 

         │          raw           │             unique              
         ├────────┬────────┬──────┼────────┬────────┬───────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff          
─────────┼────────┼────────┼──────┼────────┼────────┼───────────────
   files │      2 │      2 │    0 │        │        │               
 strings │  91363 │  91369 │   +6 │  76565 │  76571 │  +6 (+9 -3)   
   types │  24242 │  24246 │   +4 │  21859 │  21863 │  +4 (+6 -2)   
 classes │  19726 │  19730 │   +4 │  19726 │  19730 │  +4 (+6 -2)   
 methods │ 104088 │ 104098 │  +10 │  99648 │  99658 │ +10 (+20 -10) 
  fields │ 104123 │ 104127 │   +4 │ 102793 │ 102797 │  +4 (+7 -3)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  334 │  334 │  0   
 entries │ 6421 │ 6421 │  0

APK

    compressed    │    uncompressed     │                                
─────────┬────────┼──────────┬──────────┤                                
 size    │ diff   │ size     │ diff     │ path                           
─────────┼────────┼──────────┼──────────┼────────────────────────────────
 2.1 MiB │ +387 B │  5.9 MiB │ +1.2 KiB │ ∆ classes2.dex                 
 6.9 KiB │ +229 B │  6.7 KiB │   +229 B │ ∆ assets/dexopt/baseline.prof  
   815 B │   +5 B │    683 B │     +5 B │ ∆ assets/dexopt/baseline.profm 
 3.5 MiB │   -2 B │    9 MiB │      0 B │ ∆ classes.dex                  
─────────┼────────┼──────────┼──────────┼────────────────────────────────
 5.7 MiB │ +619 B │ 14.9 MiB │ +1.5 KiB │ (total)

DEX

STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   76565 │ 76571 │ +6 (+9 -3) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:58f8aee,r8-mode:compatibility,version:3.3.83}
  + Lcom/stripe/android/utils/ActivityUtilsKt;
  + Lcom/stripe/android/view/AddPaymentMethodActivity_onCreate_1;
  + Lcom/stripe/android/view/PaymentFlowActivity_onCreate_1;
  + Lcom/stripe/android/view/PaymentFlowActivity_onCreate_3;
  + Lcom/stripe/android/view/PaymentMethodsActivity_onCreate_1;
  + Lcom/stripe/android/view/PaymentMethodsActivity_onCreate_5;
  + argsAreInvalid
  + earlyExitDueToIllegalState
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:3911fc4,r8-mode:compatibility,version:3.3.83}
  - Lcom/stripe/android/view/PaymentFlowActivity_onCreate_2;
  - Lcom/stripe/android/view/PaymentMethodsActivity_onCreate_2;
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   21859 │ 21863 │ +4 (+6 -2) 
  + Lcom/stripe/android/utils/ActivityUtilsKt;
  + Lcom/stripe/android/view/AddPaymentMethodActivity_onCreate_1;
  + Lcom/stripe/android/view/PaymentFlowActivity_onCreate_1;
  + Lcom/stripe/android/view/PaymentFlowActivity_onCreate_3;
  + Lcom/stripe/android/view/PaymentMethodsActivity_onCreate_1;
  + Lcom/stripe/android/view/PaymentMethodsActivity_onCreate_5;
  
  - Lcom/stripe/android/view/PaymentFlowActivity_onCreate_2;
  - Lcom/stripe/android/view/PaymentMethodsActivity_onCreate_2;
  

METHODS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   99648 │ 99658 │ +10 (+20 -10) 
  + com.stripe.android.utils.ActivityUtilsKt argsAreInvalid(Activity, a) → boolean
  + com.stripe.android.view.AddPaymentMethodActivity_onCreate_1 <init>(AddPaymentMethodActivity)
  + com.stripe.android.view.AddPaymentMethodActivity_onCreate_1 invoke() → Object
  + com.stripe.android.view.AddPaymentMethodActivity_onCreate_1 invoke()
  + com.stripe.android.view.PaymentFlowActivity_onCreate_1 <init>(PaymentFlowActivity)
  + com.stripe.android.view.PaymentFlowActivity_onCreate_1 invoke() → Object
  + com.stripe.android.view.PaymentFlowActivity_onCreate_1 invoke()
  + com.stripe.android.view.PaymentFlowActivity_onCreate_3 <init>(PaymentFlowActivity)
  + com.stripe.android.view.PaymentFlowActivity_onCreate_3 onPageScrollStateChanged(int)
  + com.stripe.android.view.PaymentFlowActivity_onCreate_3 onPageScrolled(int, float, int)
  + com.stripe.android.view.PaymentFlowActivity_onCreate_3 onPageSelected(int)
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_1 <init>(PaymentMethodsActivity)
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_1 invoke() → Object
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_1 invoke()
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_3 invoke(String)
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_4 <init>(PaymentMethodsActivity)
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_4 invoke(Boolean)
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_5 <init>(d)
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_5 invoke(Object) → Object
  + com.stripe.android.view.PaymentMethodsActivity_onCreate_5 invoke(AddPaymentMethodActivityStarter_Args)
  
  - com.stripe.android.view.PaymentFlowActivity_onCreate_2 <init>(PaymentFlowActivity)
  - com.stripe.android.view.PaymentFlowActivity_onCreate_2 onPageScrollStateChanged(int)
  - com.stripe.android.view.PaymentFlowActivity_onCreate_2 onPageScrolled(int, float, int)
  - com.stripe.android.view.PaymentFlowActivity_onCreate_2 onPageSelected(int)
  - com.stripe.android.view.PaymentMethodsActivity_onCreate_2 <init>(PaymentMethodsActivity)
  - com.stripe.android.view.PaymentMethodsActivity_onCreate_2 invoke(Object) → Object
  - com.stripe.android.view.PaymentMethodsActivity_onCreate_2 invoke(String)
  - com.stripe.android.view.PaymentMethodsActivity_onCreate_3 invoke(Boolean)
  - com.stripe.android.view.PaymentMethodsActivity_onCreate_4 <init>(d)
  - com.stripe.android.view.PaymentMethodsActivity_onCreate_4 invoke(AddPaymentMethodActivityStarter_Args)
  

FIELDS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   102793 │ 102797 │ +4 (+7 -3) 
  + com.stripe.android.view.AddPaymentMethodActivity_onCreate_1 this_0: AddPaymentMethodActivity
  + com.stripe.android.view.PaymentFlowActivity_onCreate_1 this_0: PaymentFlowActivity
  
...✂