Add `expand` argument to various methods on `Stripe` #5938

tillh-stripe · 2022-12-09T19:40:03Z

Summary

This pull request adds an expand argument to various methods on Stripe, defaulting to an empty list.

Motivation

RUN_MOBILESDK-1115

Testing

Added tests
Modified tests
Manually verified

Screenshots

Before	After
before screenshot	after screenshot
N/A

Changelog

~~[ADDED]~~ [CHANGED] Methods on Stripe for retrieving and confirming intents now accept an optional expand argument to expand fields in the response.

CHANGELOG.md

tillh-stripe · 2022-12-09T19:45:41Z

payments-core/src/main/java/com/stripe/android/Stripe.kt

@@ -517,6 +523,7 @@ class Stripe internal constructor(
     * | Custom return_url | WebView                | WebView           | WebView  |
     *
     * @param activity the `Activity` that is launching the payment authentication flow
+     * @param confirmSetupIntentParams a set of params with which to confirm the Setup Intent


This was missing before.

tillh-stripe · 2022-12-09T19:45:52Z

payments-core/src/main/java/com/stripe/android/Stripe.kt

@@ -558,6 +565,7 @@ class Stripe internal constructor(
     * | Custom return_url | WebView                | WebView           | WebView  |
     *
     * @param fragment the `Fragment` that is launching the payment authentication flow
+     * @param confirmSetupIntentParams a set of params with which to confirm the Setup Intent


This was also missing before.

github-actions · 2022-12-09T19:49:59Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │           uncompressed           
          ├──────────┬──────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old      │ new      │ diff     │ old       │ new       │ diff     
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
      dex │  5.7 MiB │  5.7 MiB │   +438 B │  14.9 MiB │  14.9 MiB │   +1 KiB 
     arsc │    2 MiB │    2 MiB │      0 B │     2 MiB │     2 MiB │      0 B 
 manifest │  4.4 KiB │  4.4 KiB │      0 B │  20.8 KiB │  20.8 KiB │      0 B 
      res │  1.1 MiB │  1.1 MiB │      0 B │   1.8 MiB │   1.8 MiB │      0 B 
   native │  2.6 MiB │  2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │    3 MiB │    3 MiB │ +1.5 KiB │     3 MiB │     3 MiB │ +1.5 KiB 
    other │ 82.9 KiB │ 82.9 KiB │      0 B │ 158.3 KiB │ 158.3 KiB │      0 B 
──────────┼──────────┼──────────┼──────────┼───────────┼───────────┼──────────
    total │ 14.4 MiB │ 14.4 MiB │ +1.9 KiB │  27.9 MiB │  27.9 MiB │ +2.5 KiB 

         │          raw           │             unique             
         ├────────┬────────┬──────┼────────┬────────┬──────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff         
─────────┼────────┼────────┼──────┼────────┼────────┼──────────────
   files │      2 │      2 │    0 │        │        │              
 strings │  91366 │  91367 │   +1 │  76580 │  76581 │ +1 (+1 -0)   
   types │  24250 │  24250 │    0 │  21877 │  21877 │  0 (+0 -0)   
 classes │  19740 │  19740 │    0 │  19740 │  19740 │  0 (+0 -0)   
 methods │ 104015 │ 104020 │   +5 │  99677 │  99681 │ +4 (+18 -14) 
  fields │ 104185 │ 104189 │   +4 │ 102843 │ 102847 │ +4 (+4 -0)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  334 │  334 │  0   
 entries │ 6421 │ 6421 │  0

APK

     compressed     │    uncompressed    │                                
─────────┬──────────┼─────────┬──────────┤                                
 size    │ diff     │ size    │ diff     │ path                           
─────────┼──────────┼─────────┼──────────┼────────────────────────────────
 8.3 KiB │ +1.5 KiB │ 8.2 KiB │ +1.5 KiB │ ∆ assets/dexopt/baseline.prof  
 3.5 MiB │   +438 B │   9 MiB │   +1 KiB │ ∆ classes.dex                  
   805 B │     +4 B │   673 B │     +4 B │ ∆ assets/dexopt/baseline.profm 
─────────┼──────────┼─────────┼──────────┼────────────────────────────────
 3.6 MiB │ +1.9 KiB │   9 MiB │ +2.5 KiB │ (total)

DEX

STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   76580 │ 76581 │ +1 (+1 -0) 
  + _expand
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   99677 │ 99681 │ +4 (+18 -14) 
  + com.stripe.android.Stripe_retrievePaymentIntent_1 <init>(Stripe, String, String, List, d)
  + com.stripe.android.Stripe_retrievePaymentIntentSynchronous_1 <init>(Stripe, String, String, List, d)
  + com.stripe.android.Stripe_retrieveSetupIntent_1 <init>(Stripe, String, String, List, d)
  + com.stripe.android.Stripe_retrieveSetupIntentSynchronous_1 <init>(Stripe, String, String, List, d)
  + com.stripe.android.Stripe retrievePaymentIntent(String, String, List, ApiResultCallback)
  + com.stripe.android.Stripe retrievePaymentIntent_default(Stripe, String, String, List, ApiResultCallback, int, Object)
  + com.stripe.android.Stripe retrievePaymentIntentSynchronous(String, String, List) → PaymentIntent
  + com.stripe.android.Stripe retrievePaymentIntentSynchronous_default(Stripe, String, String, List, int, Object) → PaymentIntent
  + com.stripe.android.Stripe retrieveSetupIntent(String, String, List, ApiResultCallback)
  + com.stripe.android.Stripe retrieveSetupIntent_default(Stripe, String, String, List, ApiResultCallback, int, Object)
  + com.stripe.android.Stripe retrieveSetupIntentSynchronous(String, String, List) → SetupIntent
  + com.stripe.android.Stripe retrieveSetupIntentSynchronous_default(Stripe, String, String, List, int, Object) → SetupIntent
  + com.stripe.android.StripeKtxKt confirmSetupIntent(Stripe, ConfirmSetupIntentParams, String, List, d) → Object
  + com.stripe.android.StripeKtxKt confirmSetupIntent_default(Stripe, ConfirmSetupIntentParams, String, List, d, int, Object) → Object
  + com.stripe.android.StripeKtxKt retrievePaymentIntent(Stripe, String, String, List, d) → Object
  + com.stripe.android.StripeKtxKt retrievePaymentIntent_default(Stripe, String, String, List, d, int, Object) → Object
  + com.stripe.android.StripeKtxKt retrieveSetupIntent(Stripe, String, String, List, d) → Object
  + com.stripe.android.StripeKtxKt retrieveSetupIntent_default(Stripe, String, String, List, d, int, Object) → Object
  
  - com.stripe.android.Stripe_retrievePaymentIntent_1 <init>(Stripe, String, String, d)
  - com.stripe.android.Stripe_retrievePaymentIntentSynchronous_1 <init>(Stripe, String, String, d)
  - com.stripe.android.Stripe_retrieveSetupIntent_1 <init>(Stripe, String, String, d)
  - com.stripe.android.Stripe_retrieveSetupIntentSynchronous_1 <init>(Stripe, String, String, d)
  - com.stripe.android.Stripe retrievePaymentIntent_default(Stripe, String, String, ApiResultCallback, int, Object)
  - com.stripe.android.Stripe retrievePaymentIntentSynchronous_default(Stripe, String, String, int, Object) → PaymentIntent
  - com.stripe.android.Stripe retrieveSetupIntent_default(Stripe, String, String, ApiResultCallback, int, Object)
  - com.stripe.android.Stripe retrieveSetupIntentSynchronous_default(Stripe, String, String, int, Object) → SetupIntent
  - com.stripe.android.StripeKtxKt confirmSetupIntent(Stripe, ConfirmSetupIntentParams, String, d) → Object
  - com.stripe.android.StripeKtxKt confirmSetupIntent_default(Stripe, ConfirmSetupIntentParams, String, d, int, Object) → Object
  - com.stripe.android.StripeKtxKt retrievePaymentIntent(Stripe, String, String, d) → Object
  - com.stripe.android.StripeKtxKt retrievePaymentIntent_default(Stripe, String, String, d, int, Object) → Object
  - com.stripe.android.StripeKtxKt retrieveSetupIntent(Stripe, String, String, d) → Object
  - com.stripe.android.StripeKtxKt retrieveSetupIntent_default(Stripe, String, String, d, int, Object) → Object
  

FIELDS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   102843 │ 102847 │ +4 (+4 -0) 
  + com.stripe.android.Stripe_retrievePaymentIntent_1 _expand: List
  + com.stripe.android.Stripe_retrievePaymentIntentSynchronous_1 _expand: List
  + com.stripe.android.Stripe_retrieveSetupIntent_1 _expand: List
  + com.stripe.android.Stripe_retrieveSetupIntentSynchronous_1 _expand: List

jaynewstrom-stripe

LGTM, would be nice to add a test if possible.

tillh-stripe added 2 commits December 9, 2022 14:37

Add optional expand argument to several methods

4cc512b

Update changelog

349ff87

tillh-stripe force-pushed the tillh/stripe-expand-argument branch from 277eb0b to 349ff87 Compare December 9, 2022 19:40

tillh-stripe commented Dec 9, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

tillh-stripe commented Dec 9, 2022

View reviewed changes

Update API

32a4d05

tillh-stripe marked this pull request as ready for review December 9, 2022 21:18

tillh-stripe requested review from jaynewstrom-stripe, ccen-stripe, awush-stripe, jameswoo-stripe and carlosmuvi-stripe as code owners December 9, 2022 21:18

jaynewstrom-stripe previously approved these changes Dec 9, 2022

View reviewed changes

jameswoo-stripe previously approved these changes Dec 9, 2022

View reviewed changes

tillh-stripe added 2 commits December 10, 2022 09:41

Update tests

4ce9ce4

Tweak changelog message

7d57811

tillh-stripe dismissed stale reviews from jameswoo-stripe and jaynewstrom-stripe via 7d57811 December 12, 2022 14:29

jaynewstrom-stripe approved these changes Dec 12, 2022

View reviewed changes

tillh-stripe merged commit b416061 into master Dec 12, 2022

tillh-stripe deleted the tillh/stripe-expand-argument branch December 12, 2022 15:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `expand` argument to various methods on `Stripe` #5938

Add `expand` argument to various methods on `Stripe` #5938

tillh-stripe commented Dec 9, 2022 •

edited

tillh-stripe Dec 9, 2022

tillh-stripe Dec 9, 2022

github-actions bot commented Dec 9, 2022 •

edited

jaynewstrom-stripe left a comment

Add expand argument to various methods on Stripe #5938

Add expand argument to various methods on Stripe #5938

Conversation

tillh-stripe commented Dec 9, 2022 • edited

Summary

Motivation

Testing

Screenshots

Changelog

tillh-stripe Dec 9, 2022

Choose a reason for hiding this comment

tillh-stripe Dec 9, 2022

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2022 • edited

jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

Add `expand` argument to various methods on `Stripe` #5938

Add `expand` argument to various methods on `Stripe` #5938

tillh-stripe commented Dec 9, 2022 •

edited

github-actions bot commented Dec 9, 2022 •

edited