Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix primary button label regression and disable hanging tests #6136

Merged
merged 3 commits into from
Jan 30, 2023

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Jan 27, 2023

Summary

This pull request fixes the regression around the primary button label and disables some tests that succeed when run in isolation, but fail when run together.

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Fixed an issue where the primary button wouldn't show the amount for payment intents.

@tillh-stripe tillh-stripe merged commit 0dec3ec into master Jan 30, 2023
@tillh-stripe tillh-stripe deleted the tillh/tests-and-primary-button-label branch January 30, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants