Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center the payment sheet on tablets. #6172

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Feb 2, 2023

Previously it was fixed to the left side of the screen.

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before:
Screenshot_20230203_090900
After:
Screenshot_20230203_090821

Changelog

Previously it was fixed to the left side of the screen.
@jaynewstrom-stripe
Copy link
Collaborator Author

@jarvis-stripe Could you please take a look at the screenshots to ensure the updated behavior is desired?

Copy link
Collaborator

@tillh-stripe tillh-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks fine to me!

@jarvis-stripe
Copy link

@jaynewstrom-stripe looks good!

@jaynewstrom-stripe jaynewstrom-stripe merged commit 8905aaf into master Feb 6, 2023
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/center-tablet-view branch February 6, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants