Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Payment Sheet support for Zip #6283

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

nahirniak-stripe
Copy link
Contributor

@nahirniak-stripe nahirniak-stripe commented Feb 28, 2023

Summary

The PR adds Payment Sheet for Zip on Android. I used LUXE guideline and MobilePay as the reference implementation.

Motivation

To engage more users

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Zip in PMs selector:

Screenshot_20230228_004701

Redirect:

Screenshot_20230228_004741

Success:

Screenshot_20230228_004753

Changelog

  • [Added] Payment Sheet support for Zip

@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed            │           uncompressed           
          ├──────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old      │ new       │ diff     │ old       │ new       │ diff     
──────────┼──────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │  3.2 MiB │   3.2 MiB │    +98 B │   7.1 MiB │   7.1 MiB │   +176 B 
     arsc │  2.1 MiB │   2.1 MiB │   +880 B │   2.1 MiB │   2.1 MiB │   +880 B 
 manifest │  4.4 KiB │   4.4 KiB │      0 B │    21 KiB │    21 KiB │      0 B 
      res │    1 MiB │     1 MiB │ +1.1 KiB │   1.8 MiB │   1.8 MiB │ +2.3 KiB 
   native │  2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │    3 MiB │     3 MiB │    +94 B │     3 MiB │     3 MiB │   +715 B 
    other │  200 KiB │ 200.1 KiB │    +86 B │ 453.6 KiB │ 453.7 KiB │   +164 B 
──────────┼──────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │ 12.1 MiB │  12.2 MiB │ +2.2 KiB │  20.4 MiB │  20.4 MiB │ +4.2 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 35012 │ 35012 │  0 (+1 -1) 
   types │ 11485 │ 11485 │  0 (+0 -0) 
 classes │  9627 │  9627 │  0 (+0 -0) 
 methods │ 51569 │ 51569 │  0 (+0 -0) 
  fields │ 32493 │ 32494 │ +1 (+1 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  333 │  333 │  0         
 entries │ 6871 │ 6873 │ +2 (+2 -0)
APK
     compressed      │     uncompressed     │                        
──────────┬──────────┼───────────┬──────────┤                        
 size     │ diff     │ size      │ diff     │ path                   
──────────┼──────────┼───────────┼──────────┼────────────────────────
  1.1 KiB │ +1.1 KiB │   2.3 KiB │ +2.3 KiB │ + res/g1.xml           
  2.1 MiB │   +880 B │   2.1 MiB │   +880 B │ ∆ resources.arsc       
  3.2 MiB │    +98 B │   7.1 MiB │   +176 B │ ∆ classes.dex          
  2.2 KiB │    +94 B │  13.8 KiB │   +715 B │ ∆ assets/lpms.json     
 50.5 KiB │    +48 B │ 146.4 KiB │    +82 B │ ∆ META-INF/MANIFEST.MF 
 65.3 KiB │    +38 B │ 146.5 KiB │    +82 B │ ∆ META-INF/CERT.SF     
    997 B │     -1 B │   2.8 KiB │      0 B │ ∆ res/AE.xml           
──────────┼──────────┼───────────┼──────────┼────────────────────────
  5.5 MiB │ +2.2 KiB │   9.5 MiB │ +4.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   35012 │ 35012 │ 0 (+1 -1) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:33ba616,r8-mode:full,version:4.0.52}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:c316e12,r8-mode:full,version:4.0.52}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   32493 │ 32494 │ +1 (+1 -0) 
  + cd.s s: r
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6871 │ 6873 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_zip
  + string/stripe_paymentsheet_payment_method_zip

@nahirniak-stripe nahirniak-stripe enabled auto-merge (squash) February 28, 2023 01:06
@jaynewstrom-stripe
Copy link
Collaborator

LGTM, @nahirniak-stripe if you want the changelog information to be visible to consumers, you'll need to update CHANGELOG.md.

@jameswoo-stripe jameswoo-stripe force-pushed the nahirniak/add_payment_sheet_to_zip branch from 7a713ed to 5bde45e Compare February 28, 2023 20:11
@nahirniak-stripe nahirniak-stripe merged commit a85f019 into master Feb 28, 2023
@nahirniak-stripe nahirniak-stripe deleted the nahirniak/add_payment_sheet_to_zip branch February 28, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants