Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ClassCastException in PaymentSheetContract #6366

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented Mar 15, 2023

Summary

This pull request fixes a ClassCastException in PaymentSheetResult. The issue originated when we switched to using PaymentSheetContractV2 internally.

Motivation

#6365

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

[FIXED] Fixed an issue where the result couldn't be parsed in PaymentSheetContract.

@tillh-stripe tillh-stripe marked this pull request as ready for review March 15, 2023 13:25
@tillh-stripe tillh-stripe requested review from a team as code owners March 15, 2023 13:25
@tillh-stripe tillh-stripe requested review from ccen-stripe and jaynewstrom-stripe and removed request for ccen-stripe March 15, 2023 13:25
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine keeping what you have, or consider using the updates 🤷

## XX.XX.XX - 2023-XX-XX

### PaymentSheet
* [FIXED][6366](https://github.com/stripe/stripe-android/pull/6366) Fixed an issue where the result couldn't be parsed in `PaymentSheetContract`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [FIXED][6366](https://github.com/stripe/stripe-android/pull/6366) Fixed an issue where the result couldn't be parsed in `PaymentSheetContract`.
* [FIXED][6366](https://github.com/stripe/stripe-android/pull/6366) Fixed an issue where the result couldn't be parsed when using `PaymentSheetContract` directly.

@tillh-stripe tillh-stripe merged commit 3893d62 into master Mar 15, 2023
@tillh-stripe tillh-stripe deleted the tillh/6365-paymentsheetcontract-issue branch March 15, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants