[FC] Fix Accessible data callout copy logic #6375
Conversation
…uested-copy-fix # Conflicts: # financial-connections/src/main/java/com/stripe/android/financialconnections/features/accountpicker/AccountPickerViewModel.kt
| } | ||
|
|
||
| false -> when (model.businessName) { | ||
| model.isStripeDirect -> when (model.businessName) { |
There was a problem hiding this comment.
for iOS there is no conditional around businessName for isStripeDirect
There was a problem hiding this comment.
not sure if it can happen, but let's leave it just in case? 😄
There was a problem hiding this comment.
There was a problem hiding this comment.
oh! yeah this is wrong then. Updating it, thanks!
| @@ -46,6 +46,8 @@ | |||
| <string name="data_accessible_callout_no_business"><annotation bold="accessible_data">Data accessible to this business: </annotation>%1$s.<annotation clickable="learn_more"> Learn more</annotation></string> | |||
There was a problem hiding this comment.
This is debatable and likely doesn't cause an issue unless we do things like making the link underline, but the annotation itself contains a space:
<annotation clickable="learn_more"> Learn more</annotation>
so if annotation did underline, the space would have an underline
(again, likely not a legit issue, just calling it out in case there could be issues)
There was a problem hiding this comment.
It's a good point, fixed it! e4133f5
...ava/com/stripe/android/financialconnections/features/accountpicker/AccountPickerViewModel.kt
Show resolved
Hide resolved
carlosmuvi-stripe
added
the
financial-connections
Summary
Changelog