Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI for no search results in institution picker #6404

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Mar 21, 2023

Summary

  • Adds new show_manual_entry to search response.
  • Shows new UI (see Figma + screenshots).
  • Fixes previews + screenshot tests by passing an initial text as a parameter.
  • Adds previews + screenshot tests for all possible states.

Motivation

馃摂 聽Update UI for no search results in institution picker
馃寪 聽BANKCON-6403

Figma:

https://www.figma.com/file/nY1gZ4nuSmmDCUOysKSpzU/Connections---Auth-Flow-v2.1?node-id=9786-51341&t=ywXuuaABNj52wZlt-0

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Search with results (with vs without manual entry)
image

Search without results (with vs without manual entry)
image

Search failed (with vs without manual entry)
image

@carlosmuvi-stripe carlosmuvi-stripe added the work-cli Added to pull requests created with #work-cli for usage tracking. label Mar 21, 2023
@carlosmuvi-stripe carlosmuvi-stripe self-assigned this Mar 21, 2023
@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review March 22, 2023 21:59
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team as code owners March 22, 2023 21:59
@carlosmuvi-stripe carlosmuvi-stripe merged commit 475f055 into master Mar 24, 2023
@carlosmuvi-stripe carlosmuvi-stripe deleted the carlosmuvi/BANKCON-6403/update-ui-for-no-search-results-in-institution-pic branch March 24, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-cli Added to pull requests created with #work-cli for usage tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants