-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Google Pay button #6471
Update Google Pay button #6471
Conversation
87ff129
to
2a911fd
Compare
Diffuse output:
APK
DEX
ARSC
|
2a911fd
to
a4f1d9d
Compare
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Outdated
Show resolved
Hide resolved
a4f1d9d
to
560a962
Compare
link/src/main/java/com/stripe/android/link/ui/LinkButtonView.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Outdated
Show resolved
Hide resolved
53d1d01
to
3e68ea2
Compare
We got UX approval from @jarvis-stripe as well. |
d52c57c
to
97d1c28
Compare
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Outdated
Show resolved
Hide resolved
link/src/main/java/com/stripe/android/link/ui/LinkButtonView.kt
Outdated
Show resolved
Hide resolved
link/src/main/java/com/stripe/android/link/ui/LinkButtonView.kt
Outdated
Show resolved
Hide resolved
0dd2a0a
to
4502199
Compare
Risky Change This is considered a risky change because it adjusts the sample app build.gradle, please review carefully. By adding the label |
0a9e0ef
to
bcb71c6
Compare
bcb71c6
to
8093ea9
Compare
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/GooglePayButton.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/PaymentSheetScreen.kt
Outdated
Show resolved
Hide resolved
LabelUI( | ||
label = text, | ||
color = defaultLabelColor, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m not entirely clear on why we need this now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to be able to change the label color when user switches between light/dark theme. Exposed in setDefaultLabelColor
val padding = context.resources.getDimensionPixelSize( | ||
R.dimen.stripe_paymentsheet_googlepay_button_bottom_padding | ||
) | ||
viewBinding.googlePayButtonLayout.updatePadding(bottom = padding) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to update the padding when we start processing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the Google Pay button changes to not visible, the padding that the Google Pay button had goes away, so we need to adjust for this.
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/GooglePayButton.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/GooglePayButton.kt
Outdated
Show resolved
Hide resolved
45b8e2a
to
9d0a072
Compare
paymentsheet/src/main/java/com/stripe/android/paymentsheet/ui/GooglePayButton.kt
Outdated
Show resolved
Hide resolved
@@ -2,6 +2,9 @@ | |||
|
|||
## XX.XX.XX - 2023-XX-XX | |||
|
|||
### PaymentSheet | |||
* [CHANGED][6471](https://github.com/stripe/stripe-android/pull/6471) Updated Google Pay button to match new brand guidelines. You can now change the radius of the Google Pay and Link button with the [Appearance API](https://stripe.com/docs/elements/appearance-api?platform=android#shapes-android). Additionally, this change updates the `com.google.android.gms:play-services-wallet` version from `19.1.0` to `19.2.0-beta01`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think we need this addition.
* [CHANGED][6471](https://github.com/stripe/stripe-android/pull/6471) Updated Google Pay button to match new brand guidelines. You can now change the radius of the Google Pay and Link button with the [Appearance API](https://stripe.com/docs/elements/appearance-api?platform=android#shapes-android). Additionally, this change updates the `com.google.android.gms:play-services-wallet` version from `19.1.0` to `19.2.0-beta01`. | |
* [CHANGED][6471](https://github.com/stripe/stripe-android/pull/6471) Updated Google Pay button to match new brand guidelines. You can now change the radius of the Google Pay and Link button with the [Appearance API](https://stripe.com/docs/elements/appearance-api?platform=android#shapes-android). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaynewstrom-stripe thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely call it out. Could be a separate line item/section though.
…for icons. Remove night mode for Google Pay assets and set them manually depending on the surface color.
09ce0d1
to
d43c707
Compare
d43c707
to
588422a
Compare
Summary
Previous work to update the Google Pay button: #5487
com.google.android.gms:play-services-wallet
version from19.1.0
to19.2.0-beta01
.Motivation
Google Pay branding guidelines changed.
Testing
Screenshots
Changelog
com.google.android.gms:play-services-wallet
version from19.1.0
to19.2.0-beta01
.