Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn on classes that aren't available due to compile only dependencies. #6612

Merged
merged 2 commits into from
Apr 27, 2023

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Apr 27, 2023

Fixes #6577

Summary

Update proguard rules to not warn on compile only dependencies. These are expected, and we've planned for it!

Motivation

#6577

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

  • [FIXED]6612 Fixed an issue where the Android Gradle Plugin 8.0 and later would cause issues with R8 in full mode related to missing classes.

@jaynewstrom-stripe jaynewstrom-stripe requested review from a team and tillh-stripe and removed request for a team April 27, 2023 17:02
@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review April 27, 2023 17:12
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners April 27, 2023 17:12
@github-actions
Copy link
Contributor

github-actions bot commented Apr 27, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │   3.3 MiB │   3.3 MiB │  0 B │   7.3 MiB │   7.3 MiB │  0 B 
     arsc │   2.1 MiB │   2.1 MiB │  0 B │   2.1 MiB │   2.1 MiB │  0 B 
 manifest │   4.6 KiB │   4.6 KiB │  0 B │  22.3 KiB │  22.3 KiB │  0 B 
      res │ 866.9 KiB │ 866.9 KiB │  0 B │   1.3 MiB │   1.3 MiB │  0 B 
   native │   2.6 MiB │   2.6 MiB │  0 B │     6 MiB │     6 MiB │  0 B 
    asset │     3 MiB │     3 MiB │  0 B │     3 MiB │     3 MiB │  0 B 
    other │ 199.5 KiB │ 199.5 KiB │  0 B │ 446.8 KiB │ 446.8 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │    12 MiB │    12 MiB │  0 B │  20.2 MiB │  20.2 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 35776 │ 35776 │ 0 (+0 -0) 
   types │ 11812 │ 11812 │ 0 (+0 -0) 
 classes │  9924 │  9924 │ 0 (+0 -0) 
 methods │ 52687 │ 52687 │ 0 (+0 -0) 
  fields │ 33486 │ 33486 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  291 │  291 │  0   
 entries │ 6914 │ 6914 │  0

@jaynewstrom-stripe jaynewstrom-stripe merged commit deaf94c into master Apr 27, 2023
9 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/support-latest-agp-r8 branch April 27, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] R8 gives error of missing classes
2 participants