Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add polling for Cash App Pay flow result processing #6680

Merged
merged 4 commits into from
May 15, 2023

Conversation

tillh-stripe
Copy link
Collaborator

@tillh-stripe tillh-stripe commented May 5, 2023

Summary

This pull request adds polling for Cash App Pay payments in the PaymentFlowResultProcessor to adapt to the backend changes.

(cc @porter-stripe)

Motivation

More resilient Cash App Pay payments.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │         uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff  
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
      dex │   3.4 MiB │   3.4 MiB │ +180 B │   7.4 MiB │   7.4 MiB │ +64 B 
     arsc │   2.1 MiB │   2.1 MiB │    0 B │   2.1 MiB │   2.1 MiB │   0 B 
 manifest │   4.6 KiB │   4.6 KiB │    0 B │  22.3 KiB │  22.3 KiB │   0 B 
      res │ 869.1 KiB │ 869.1 KiB │    0 B │   1.3 MiB │   1.3 MiB │   0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │   0 B 
    asset │     3 MiB │     3 MiB │    0 B │     3 MiB │     3 MiB │   0 B 
    other │ 199.7 KiB │ 199.7 KiB │   +1 B │ 446.8 KiB │ 446.8 KiB │   0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼───────
    total │  12.1 MiB │  12.1 MiB │ +181 B │  20.3 MiB │  20.3 MiB │ +64 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 36239 │ 36239 │  0 (+1 -1) 
   types │ 12046 │ 12046 │  0 (+0 -0) 
 classes │ 10146 │ 10146 │  0 (+0 -0) 
 methods │ 53659 │ 53659 │  0 (+0 -0) 
  fields │ 34114 │ 34115 │ +1 (+2 -1) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  291 │  291 │  0   
 entries │ 6942 │ 6942 │  0
APK
    compressed     │   uncompressed    │                        
──────────┬────────┼───────────┬───────┤                        
 size     │ diff   │ size      │ diff  │ path                   
──────────┼────────┼───────────┼───────┼────────────────────────
  3.4 MiB │ +180 B │   7.4 MiB │ +64 B │ ∆ classes.dex          
 48.5 KiB │   +3 B │ 140.8 KiB │   0 B │ ∆ META-INF/MANIFEST.MF 
 62.7 KiB │   -2 B │ 140.9 KiB │   0 B │ ∆ META-INF/CERT.SF     
──────────┼────────┼───────────┼───────┼────────────────────────
  3.5 MiB │ +181 B │   7.7 MiB │ +64 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   36239 │ 36239 │ 0 (+1 -1) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:d552af5,r8-mode:full,version:8.0.40}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:dced842,r8-mode:full,version:8.0.40}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   34114 │ 34115 │ +1 (+2 -1) 
  + hc.m2 w: m2
  + hc.m2 x: m2[]
  
  - hc.m2 w: m2[]

@tillh-stripe tillh-stripe force-pushed the tillh/cap-polling branch 2 times, most recently from 7abda98 to 224befb Compare May 5, 2023 14:51
@tillh-stripe tillh-stripe changed the title Add polling for CAP Add polling for Cash App Pay flow result processing May 11, 2023
@tillh-stripe tillh-stripe marked this pull request as ready for review May 11, 2023 19:32
@tillh-stripe tillh-stripe requested review from a team as code owners May 11, 2023 19:32
@tillh-stripe tillh-stripe merged commit ee6e68c into master May 15, 2023
8 checks passed
@tillh-stripe tillh-stripe deleted the tillh/cap-polling branch May 15, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants