Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] ImageDecoder: Exception in invokeOnCancellation handler #6698

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented May 10, 2023

Summary

  • Problem: we're seeing some crashes when the cancellation logic of our internal ImageDecoder throws an exception.
    • On coroutine cancellation, we attempt to close the InputStream fetching the image.
    • This cancellation can fail (example failure we're sometimes seeing: Okhttp throws unbalanced enter/exit)
  • Solution: we should be ignoring errors happening

Motivation

馃摂 聽[Android] ImageDecoder: Exception in invokeOnCancellation handler
馃寪 聽BANKCON-6830

Changelog

- [Fixed] ImageDecoder: Exception in invokeOnCancellation handler

@carlosmuvi-stripe carlosmuvi-stripe added the work-cli Added to pull requests created with #work-cli for usage tracking. label May 10, 2023
@carlosmuvi-stripe carlosmuvi-stripe self-assigned this May 10, 2023
Copy link
Contributor

@vardges-stripe vardges-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review May 10, 2023 19:46
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team as code owners May 10, 2023 19:46
@carlosmuvi-stripe carlosmuvi-stripe enabled auto-merge (squash) May 10, 2023 19:54
@carlosmuvi-stripe carlosmuvi-stripe merged commit 9909158 into master May 10, 2023
6 checks passed
@carlosmuvi-stripe carlosmuvi-stripe deleted the carlosmuvi/BANKCON-6830/android-imagedecoder-exception-in-invokeoncancella branch May 10, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work-cli Added to pull requests created with #work-cli for usage tracking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants