Add ability to set card number and validate it #671
Conversation
| /** | ||
| * Checks whether the current card number is valid | ||
| */ | ||
| public boolean validateCardNumber() { |
There was a problem hiding this comment.
Appears to be unused, is that intentional? Does it need to be a public method?
There was a problem hiding this comment.
It is intentional. We are adding the ability for our users to call this. I think there's cases where they will want to just add the number and cases when they will want to add it validate it so we allow them to do both.
There was a problem hiding this comment.
Should we add a test for this method then?
| * | ||
| * @param cardNumber card number to be set | ||
| */ | ||
| public void setCardNumber(String cardNumber) { |
There was a problem hiding this comment.
Can you add tests for the various types of card numbers (e.g. cards with spaces, cards without?)
There was a problem hiding this comment.
Added them. Though, TBH, I don't think adding tests here do adds that much safety. More test is better than fewer and this doesn't feel like a fragile test so I'm in the it can't hurt camp.
This is a one line wrapper file that exists to expose existing functionality to users on the SDK. That existing functionality is already tested
There was a problem hiding this comment.
Also one more nit, might be good practice to annotate new methods we add (@NonNull in this case)
In response to:
#508