Move Decoupling to GA #6857
Move Decoupling to GA #6857
Conversation
tillh-stripe
force-pushed
the
tillh/decoupling-ga
branch
from
d1fb47a
to
8dca888
Compare
tillh-stripe
force-pushed
the
tillh/decoupling-ga
branch
from
68a25c0
to
f224cac
Compare
| @@ -1,5 +1,9 @@ | |||
| package com.stripe.android.paymentsheet | |||
|
|
|||
| @Deprecated( | |||
| message = "This feature is no longer experimental. You can remove the annotation.", | |||
| level = DeprecationLevel.HIDDEN, | |||
There was a problem hiding this comment.
Should this be a DeprecationLevel.WARNING instead? I initially wanted to use HIDDEN to not expose it to new users, but not sure if we want to force removal for existing beta users.
There was a problem hiding this comment.
Should we just remove it? Feels acceptable to me.
There was a problem hiding this comment.
I like the idea of us providing them with some information instead of just removing it, possibly adding confusion.
There was a problem hiding this comment.
I was thinking the other side of confusion :O Maybe a user sees the annotation is deprecated, and thinks we deprecated the feature!
There was a problem hiding this comment.
That’s why there’s a message 🙃
There was a problem hiding this comment.
What's the user experience if it's removed? Will they see a mysterious compiler error?
tillh-stripe
requested review from
awush-stripe,
jameswoo-stripe,
jaynewstrom-stripe and
yuki-stripe
and removed request for
awush-stripe
| @@ -1,5 +1,9 @@ | |||
| package com.stripe.android.paymentsheet | |||
|
|
|||
| @Deprecated( | |||
| message = "This feature is no longer experimental. You can remove the annotation.", | |||
| level = DeprecationLevel.HIDDEN, | |||
There was a problem hiding this comment.
Should we just remove it? Feels acceptable to me.
Summary
This pull request moves the decoupling functionality to GA by removing the
ExperimentalPaymentSheetDecouplingApiannotation.The annotation class stays around but is marked as deprecated, helping developers understand that the API is now stable.
Motivation
Testing
Screenshots
Changelog