[Android] Replicate other platforms polling logic across the AuthFlow #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmuvi-stripe
added
the
work-cli
carlosmuvi-stripe
changed the title
Comment on lines
+8
to
+11
| internal class FetchNetworkedAccounts @Inject constructor( | ||
| private val repository: FinancialConnectionsAccountsRepository, | ||
| private val configuration: FinancialConnectionsSheet.Configuration | ||
| ) { |
There was a problem hiding this comment.
just renamed from PollNetworkedAccounts. No polling needed here.
carlosmuvi-stripe
force-pushed
the
carlosmuvi/BANKCON-7171/android-replicate-other-platforms-polling-logic-ac
branch
from
33bc8fc
to
114f16c
Compare
carlosmuvi-stripe
requested review from
awush-stripe and
ccen-stripe
and removed request for
awush-stripe
Comment on lines
+91
to
+107
| private fun FinancialConnectionsAuthorizationSession.Flow?.toPollIntervalMs(): Long { | ||
| val defaultInitialPollDelay: Long = 1.75.seconds.inWholeMilliseconds | ||
| return when (this) { | ||
| FinancialConnectionsAuthorizationSession.Flow.TESTMODE, | ||
| FinancialConnectionsAuthorizationSession.Flow.TESTMODE_OAUTH, | ||
| FinancialConnectionsAuthorizationSession.Flow.TESTMODE_OAUTH_WEBVIEW, | ||
| FinancialConnectionsAuthorizationSession.Flow.FINICITY_CONNECT_V2_LITE -> { | ||
| // Post auth flow, Finicity non-OAuth account retrieval latency is extremely quick - p90 < 1sec. | ||
| 0 | ||
| } | ||
|
|
||
| FinancialConnectionsAuthorizationSession.Flow.MX_CONNECT -> { | ||
| // 10 account retrieval latency on MX non-OAuth sessions is currently 460 ms | ||
| 0.5.seconds.inWholeMilliseconds | ||
| } | ||
|
|
||
| private companion object { | ||
| private const val POLLING_TIME_MS = 2000L | ||
| private const val MAX_TRIES = 10 | ||
| else -> defaultInitialPollDelay |
There was a problem hiding this comment.
replicated from iOS. Each flow has an optimal initial delay.
carlosmuvi-stripe
force-pushed
the
carlosmuvi/BANKCON-7171/android-replicate-other-platforms-polling-logic-ac
branch
from
7570ec0
to
3517bb5
Compare
| return retryOnException( | ||
| times = MAX_TRIES, | ||
| delayMilliseconds = POLLING_TIME_MS, | ||
| ): PartnerAccountsList = try { |
There was a problem hiding this comment.
try now wraps the retryOnException execution, so that toDomainException also maps retry exceptions.
…7171/android-replicate-other-platforms-polling-logic-ac
Co-authored-by: Till Hellmund <tillh@stripe.com>
tillh-stripe
approved these changes
Jun 26, 2023
carlosmuvi-stripe
deleted the
carlosmuvi/BANKCON-7171/android-replicate-other-platforms-polling-logic-ac
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replicates polling logic from iOS / Web:
Aditionally, throws a retryable, known
StripeException,PollingReachedMaxRetriesException, instead ofjava.concurrent.TimeoutException. There's code in place to allow user to try again on known exceptions.Before, the user would just be able to close the flow. Now the user will be able to try again or select another bank.
polling.mp4
Motivation
📔 [Android] Replicate other platforms' polling logic across the AuthFlow
🌐 BANKCON-7171
Testing