Fix Google Pay button padding issues #6992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/google-pay-button-padding
branch
from
b11a0b4
to
83bb886
Compare
jaynewstrom-stripe
previously approved these changes
Jul 12, 2023
| @@ -163,6 +164,8 @@ internal fun Wallet( | |||
| } | |||
|
|
|||
| state.link?.let { link -> | |||
| Spacer(modifier = Modifier.requiredHeight(8.dp)) | |||
There was a problem hiding this comment.
Does this mess up if google pay is not enabled?
There was a problem hiding this comment.
Oh yeah, it would. Will do a quick fix now and then revisit when we’re taking a more systematic approach to enforcing consistent spacing.
jaynewstrom-stripe
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue where incorrect padding was applied to the Google Pay button.
Motivation
Resolves #6940
Testing
Screenshots
Changelog
[Fixed] Fixed an issue where incorrect padding was set on the Google Pay button.