Fix click listener issue with Google Pay button #7136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaynewstrom-stripe
approved these changes
Aug 9, 2023
fionnbarrett-stripe
pushed a commit
that referenced
this pull request
Aug 17, 2023
* Fix click listener issue with Google Pay button * Temporarily disable tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request makes the on-click listener of PaymentSheet’s Google Pay button more reliable. Instead of setting the listener on the wrapping
GooglePayButton, we now set it directly on the providedPayButton.Motivation
#7124
Testing
Screenshots
Changelog
[FIXED] Fixed an issue where the Google Pay button in PaymentSheet was not clickable in some cases.