Add rounded corners to BottomSheet
#7144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/use-bottomsheet-for-ps
branch
3 times, most recently
from
4b1032f
to
45946ae
Compare
tillh-stripe
force-pushed
the
tillh/bottom-sheet-rounded-corners
branch
3 times, most recently
from
950f9f2
to
d9acb47
Compare
tillh-stripe
force-pushed
the
tillh/use-bottomsheet-for-ps
branch
3 times, most recently
from
4510480
to
c85c75b
Compare
tillh-stripe
force-pushed
the
tillh/bottom-sheet-rounded-corners
branch
2 times, most recently
from
b88c55b
to
9010735
Compare
jaynewstrom-stripe
previously approved these changes
Aug 21, 2023
tillh-stripe
dismissed
jaynewstrom-stripe’s stale review
The base branch was changed.
tillh-stripe
force-pushed
the
tillh/bottom-sheet-rounded-corners
branch
from
9010735
to
1573b3c
Compare
tillh-stripe
requested review from
awush-stripe,
jameswoo-stripe and
samer-stripe
and removed request for
awush-stripe
jaynewstrom-stripe
approved these changes
Aug 21, 2023
samer-stripe
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds rounded corners to
BottomSheetfor a more modern look. We use the rounded corners value as provided inPaymentSheet.Configurationto nicely fit in with the merchant’s desired look.Motivation
UX polish.
Testing
Screenshots
Changelog