Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sofort SetupIntent and PaymentIntent with SFU support #7272

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

jameswoo-stripe
Copy link
Contributor

@jameswoo-stripe jameswoo-stripe commented Sep 6, 2023

Summary

Add Sofort SetupIntent and PaymentIntent with SFU support

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

  • [ADDED]7272 PaymentSheet now supports Sofort with SetupIntent and PaymentIntent with setup for future usage.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.5 MiB │   3.5 MiB │ +197 B │   7.8 MiB │   7.8 MiB │ +148 B 
     arsc │   2.1 MiB │   2.1 MiB │    0 B │   2.1 MiB │   2.1 MiB │    0 B 
 manifest │   4.9 KiB │   4.9 KiB │    0 B │  24.1 KiB │  24.1 KiB │    0 B 
      res │ 878.8 KiB │ 878.8 KiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │     3 MiB │     3 MiB │   -7 B │     3 MiB │     3 MiB │   -7 B 
    other │   200 KiB │   200 KiB │   +5 B │ 447.5 KiB │ 447.5 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.3 MiB │  12.3 MiB │ +195 B │  20.7 MiB │  20.7 MiB │ +141 B 

 DEX     │ old   │ new   │ diff         
─────────┼───────┼───────┼──────────────
   files │     1 │     1 │  0           
 strings │ 38370 │ 38370 │  0 (+1 -1)   
   types │ 12687 │ 12687 │  0 (+0 -0)   
 classes │ 10710 │ 10710 │  0 (+0 -0)   
 methods │ 56194 │ 56195 │ +1 (+14 -13) 
  fields │ 35246 │ 35246 │  0 (+0 -0)   

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  290 │  290 │  0   
 entries │ 6932 │ 6932 │  0
APK
    compressed     │    uncompressed    │                               
──────────┬────────┼───────────┬────────┤                               
 size     │ diff   │ size      │ diff   │ path                          
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.5 MiB │ +197 B │   7.8 MiB │ +148 B │ ∆ classes.dex                 
  6.3 KiB │   -7 B │   6.2 KiB │   -7 B │ ∆ assets/dexopt/baseline.prof 
 48.6 KiB │   +5 B │ 141.1 KiB │    0 B │ ∆ META-INF/MANIFEST.MF        
 62.8 KiB │   +2 B │ 141.2 KiB │    0 B │ ∆ META-INF/CERT.SF            
  1.2 KiB │   -2 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA           
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.7 MiB │ +195 B │   8.1 MiB │ +141 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   38370 │ 38370 │ 0 (+1 -1) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:7b4fadc,r8-mode:full,version:8.0.46}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:9d2f0a5,r8-mode:full,version:8.0.46}
  

METHODS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   56194 │ 56195 │ +1 (+14 -13) 
  + f2.c A0(g5, boolean) → List
  + f2.c B0(View, e)
  + f2.c C0(View, x)
  + f2.c D0(Status, Object, i)
  + f2.c E0(float, long) → long
  + f2.c F0(Bitmap) → Size
  + f2.c G0(Object, c, e)
  + f2.c H0(v, v, e) → Object
  + f2.c I0(String) → a
  + f2.c J0(o1) → t
  + f2.c K0(long) → double
  + f2.c L0(long, long) → long
  + f2.c M0(j, Object, Object, e, d) → Object
  + f2.c N0(String, Object[]) → String
  
  - f2.c A0(View, e)
  - f2.c B0(View, x)
  - f2.c C0(Status, Object, i)
  - f2.c D0(float, long) → long
  - f2.c E0(Bitmap) → Size
  - f2.c F0(Object, c, e)
  - f2.c G0(v, v, e) → Object
  - f2.c H0(String) → a
  - f2.c I0(o1) → t
  - f2.c J0(long) → double
  - f2.c K0(long, long) → long
  - f2.c L0(j, Object, Object, e, d) → Object
  - f2.c M0(String, Object[]) → String

@@ -738,3 +726,23 @@ private fun StripeIntent.payPalRequiresMandate(): Boolean {
is SetupIntent -> true
}
}

private fun StripeIntent.sepaMandateLayout(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@jameswoo-stripe jameswoo-stripe merged commit fd02590 into master Sep 6, 2023
10 checks passed
@jameswoo-stripe jameswoo-stripe deleted the jameswoo/sofort-si-pi-sfu branch September 6, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants