Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Alipay #7274

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Add support for Alipay #7274

merged 5 commits into from
Sep 7, 2023

Conversation

eurias-stripe
Copy link
Contributor

Summary

Add support for Alipay in PaymentSheet.

Motivation

LPM Sprint

Testing

  • Added tests
  • Manually verified

Screencast

Alipay_android.mp4

Changelog

  • [ADDED] PaymentSheet now supports Alipay for PaymentIntents.

Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a file you'll have to add (otherwise a test will fail), but otherwise LGTM.

You can run SupportedPaymentMethodTest Locally.

payments-ui-core/src/main/assets/lpms.json Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.5 MiB │   3.5 MiB │   +113 B │   7.8 MiB │   7.8 MiB │   +124 B 
     arsc │   2.1 MiB │   2.1 MiB │   +720 B │   2.1 MiB │   2.1 MiB │   +720 B 
 manifest │   4.9 KiB │   4.9 KiB │      0 B │  24.1 KiB │  24.1 KiB │      0 B 
      res │ 878.8 KiB │ 879.5 KiB │   +757 B │   1.4 MiB │   1.4 MiB │ +1.2 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │    +41 B │     3 MiB │     3 MiB │   +239 B 
    other │   200 KiB │ 200.1 KiB │    +86 B │ 447.5 KiB │ 447.6 KiB │   +164 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.3 MiB │  12.3 MiB │ +1.7 KiB │  20.7 MiB │  20.7 MiB │ +2.4 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 38367 │ 38367 │  0 (+1 -1) 
   types │ 12687 │ 12687 │  0 (+0 -0) 
 classes │ 10710 │ 10710 │  0 (+0 -0) 
 methods │ 56194 │ 56194 │  0 (+0 -0) 
  fields │ 35245 │ 35246 │ +1 (+1 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  290 │  290 │  0         
 entries │ 6932 │ 6934 │ +2 (+2 -0)
APK
     compressed      │     uncompressed     │                        
──────────┬──────────┼───────────┬──────────┤                        
 size     │ diff     │ size      │ diff     │ path                   
──────────┼──────────┼───────────┼──────────┼────────────────────────
    758 B │   +758 B │   1.2 KiB │ +1.2 KiB │ + res/4X.xml           
  2.1 MiB │   +720 B │   2.1 MiB │   +720 B │ ∆ resources.arsc       
  3.5 MiB │   +113 B │   7.8 MiB │   +124 B │ ∆ classes.dex          
 62.9 KiB │    +52 B │ 141.3 KiB │    +82 B │ ∆ META-INF/CERT.SF     
  2.7 KiB │    +41 B │    22 KiB │   +239 B │ ∆ assets/lpms.json     
 48.7 KiB │    +36 B │ 141.2 KiB │    +82 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │     -2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA    
    950 B │     -1 B │   2.5 KiB │      0 B │ ∆ res/9N.xml           
    996 B │     -1 B │   2.8 KiB │      0 B │ ∆ res/XB.xml           
    850 B │     +1 B │   1.8 KiB │      0 B │ ∆ res/lK.xml           
──────────┼──────────┼───────────┼──────────┼────────────────────────
  5.8 MiB │ +1.7 KiB │  10.2 MiB │ +2.4 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   38367 │ 38367 │ 0 (+1 -1) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:827b8c9,r8-mode:full,version:8.0.46}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:5d6c7ab,r8-mode:full,version:8.0.46}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   35245 │ 35246 │ +1 (+1 -0) 
  + oe.a0 x: z
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6932 │ 6934 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_alipay
  + string/stripe_paymentsheet_payment_method_alipay

@eurias-stripe eurias-stripe merged commit 4799b27 into master Sep 7, 2023
10 checks passed
@eurias-stripe eurias-stripe deleted the eurias/alipay branch September 7, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants