Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sepa payment method form ui #7283

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

jameswoo-stripe
Copy link
Contributor

@jameswoo-stripe jameswoo-stripe commented Sep 8, 2023

Summary

Fix sepa payment method form ui. This is the client side fix to the server side updates to the lpm specs.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

sepalpms.webm

Changelog

  • [FIXED] Fixed an issue where Bancontact SetupIntent or PaymentIntent with setup for future usage would show the mandate text in the middle of the form.

samer-stripe
samer-stripe previously approved these changes Sep 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.5 MiB │   3.5 MiB │ +302 B │   7.8 MiB │   7.8 MiB │    0 B 
     arsc │   2.1 MiB │   2.1 MiB │    0 B │   2.1 MiB │   2.1 MiB │    0 B 
 manifest │   4.9 KiB │   4.9 KiB │    0 B │  24.1 KiB │  24.1 KiB │    0 B 
      res │ 879.5 KiB │ 879.5 KiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │     3 MiB │     3 MiB │  +27 B │     3 MiB │     3 MiB │ +466 B 
    other │ 200.1 KiB │ 200.1 KiB │   -9 B │ 447.6 KiB │ 447.6 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.3 MiB │  12.3 MiB │ +320 B │  20.7 MiB │  20.7 MiB │ +466 B 

 DEX     │ old   │ new   │ diff           
─────────┼───────┼───────┼────────────────
   files │     1 │     1 │  0             
 strings │ 38310 │ 38316 │ +6 (+10 -4)    
   types │ 12686 │ 12686 │  0 (+0 -0)     
 classes │ 10711 │ 10711 │  0 (+0 -0)     
 methods │ 56197 │ 56198 │ +1 (+163 -162) 
  fields │ 35255 │ 35259 │ +4 (+104 -100) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  290 │  290 │  0   
 entries │ 6935 │ 6935 │  0
APK
    compressed     │    uncompressed    │                               
──────────┬────────┼───────────┬────────┤                               
 size     │ diff   │ size      │ diff   │ path                          
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.5 MiB │ +302 B │   7.8 MiB │    0 B │ ∆ classes.dex                 
  2.7 KiB │  +18 B │  22.5 KiB │ +457 B │ ∆ assets/lpms.json            
  6.4 KiB │   +9 B │   6.3 KiB │   +9 B │ ∆ assets/dexopt/baseline.prof 
 62.9 KiB │   -9 B │ 141.3 KiB │    0 B │ ∆ META-INF/CERT.SF            
──────────┼────────┼───────────┼────────┼───────────────────────────────
  3.6 MiB │ +320 B │   7.9 MiB │ +466 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   38310 │ 38316 │ +6 (+10 -4) 
  + , placeholderOverrideList=
  + , requiredFields=
  + BillingDetailsCollectionConfiguration(collectName=
  + SepaMandate
  + VLZIILLZLLL
  + VLZZZLLLLLLZL
  + com.stripe.android.ui.core.BillingDetailsCollectionConfiguration.AddressCollectionMode
  + placeholderOverrideList
  + requiredFields
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:8e62ae1,r8-mode:full,version:8.0.46}
  
  - CardBillingDetailsCollectionConfiguration(collectName=
  - VLZZZLLLLLL
  - com.stripe.android.ui.core.CardBillingDetailsCollectionConfiguration.AddressCollectionMode
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:bad92d9,r8-mode:full,version:8.0.46}
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   56197 │ 56198 │ +1 (+163 -162) 
  + b1.j1 x0(c, c) → h3
  + f2.c A0(String) → o
  + f2.c B0(i) → float
  + f2.c C0(KeyEvent) → long
  + f2.c D(g5) → boolean
  + f2.c D0(List) → int
  + f2.c E(double) → double
  + f2.c E0(int) → String
  + f2.c F(float, float, float, l, h0, d) → Object
  + f2.c F0(b) → b
  + f2.c G(m, i, long, c, d) → Object
  + f2.c G0() → x1
  + f2.c H(l0, float, f0, i) → g0
  + f2.c H0(int) → c
  + f2.c I(m, Float, boolean, c, j) → Object
  + f2.c I0(Throwable) → boolean
  + f2.c J(l0, Number, Number, q1, f0, String, i) → g0
  + f2.c J0(String, Provider, PSSParameterSpec) → Signature
  + f2.c K(Activity, a) → boolean
  + f2.c K0(String) → String
  + f2.c L(Object[]) → ArrayList
  + f2.c L0(KeyEvent) → int
  + f2.c M(ArrayList, d) → Object
  + f2.c M0(t1, long, q, q, q) → q
  + f2.c N(n, a, d) → Object
  + f2.c N0(i, Throwable)
  + f2.c O(l, q, f0) → l
  + f2.c O0(w) → f0
  + f2.c P(l, float, long, f0) → l
  + f2.c P0(e) → boolean
  + f2.c Q(float, l, m, f0) → l
  + f2.c Q0(c) → q0
  + f2.c R(a) → a
  + f2.c R0(Object) → List
  + f2.c S(String, m, g[], c) → h
  + f2.c S0(Object[]) → List
  + f2.c T(String, m, g[]) → h
  + f2.c T0(Object) → List
  + f2.c U(Context, AttributeSet, int, int)
  + f2.c U0(Object[]) → ArrayList
  + f2.c V(m)
  + f2.c V0(c) → d0
  + f2.c W(f, d, e)
  + f2.c W0(int, Surface) → ImageWriter
  + f2.c X(Context, String) → int
  + f2.c X0(Surface, int, int) → ImageWriter
  + f2.c Y(Context, AttributeSet, int[], int, int, int[])
  + f2.c Y0(q) → q
  + f2.c Z(Context, int[], String)
  + f2.c Z0(Context, AttributeSet, int[], int, int, int[]) → TypedArray
  + f2.c a0(g, b) → String
  + f2.c a1(b, a1, long, i0, d) → Object
  + f2.c b0(Closeable, Throwable)
  + f2.c b1(List) → List
  + f2.c c0(double) → s
  + f2.c c1(int, i) → c
  + f2.c d0(i) → b
  + f2.c d1(JSONObject) → u1
  + f2.c e0(x) → z0
  + f2.c e1(Object, m) → Object
  + f2.c f0(q) → q
  + f2.c f1(ImageWriter, Image)
  + f2.c g0(m) → m
  + f2.c g1(int, int, int)
  + f2.c h0(n1, q1, String, i, int) → g1
  + f2.c h1(i) → l0
  + f2.c i0(String, Enum[], String[], Annotation[][]) → w
  + f2.c i1(j0, d, boolean)
  + f2.c j0(String, Enum[]) → w
  + f2.c j1(e, d, c, e) → Object
  + f2.c k0(Drawable, ColorStateList, PorterDuff_Mode) → Drawable
  + f2.c l0(n1, Object, Object, a0, q1, String, i) → j1
  + f2.c m0(q1, Object) → q
  + f2.c n0(String, String, Object)
  + f2.c o0(byte[]) → byte[]
  + f2.c p0(k, a) → Object
  + f2.c q0(byte[]) → byte[]
  + f2.c r0(k, long, float, i, m, c)
  + f2.c s0(l, t0, c, a1, boolean, m, a, f, f, boolean) → l
  + f2.c t0(l, t0, a1, boolean, m, boolean, f, boolean) → l
  + f2.c u0(j, d0, boolean, d) → Object
  + f2.c v0(int, int) → boolean
  + f2.c w0(View, int) → View
  + f2.c x0(b, d, Object) → b
  + f2.c y0(View) → e
  + f2.c z0() → e
  + h3.y u(e5, List, boolean, x1) → p3
  + j.g v() → q
  + jg.c <init>(String, boolean, int, int, String, String, boolean, u, j4)
  + jg.c <init>(String, boolean, int, int, String, String, boolean, u, j4, List)
  + ng.n G0() → x1
  + ng.o G0() → x1
  + ng.p G0() → x1
  + oe.a0 <init>(d)
  + oe.a0 f(Object, d) → d
  + oe.a0 j(Object) → Object
  + oe.a0 z(Object, Object) → Object
  + oe.a <init>(Object, d, int)
  + oe.a D(Object, Object, Object, Object, Object) → Object
  + oe.a j(Object) → Object
  + oe.b <clinit>()
  + oe.b <init>()
  + oe.c <init>(LinkedHashMap, boolean, i)
  + oe.c equals(Object) → boolean
  + oe.c hashCode() → int
  + oe.c toString() → String
  + oe.d <init>(q, d)
  + oe.d f(Object, d) → d
  + oe.d j(Object) → Ob
...✂

samer-stripe
samer-stripe previously approved these changes Sep 8, 2023
@jameswoo-stripe jameswoo-stripe merged commit 88572bd into master Sep 11, 2023
10 checks passed
@jameswoo-stripe jameswoo-stripe deleted the jameswoo/sepa-mandate-fix branch September 11, 2023 16:51
eurias-stripe pushed a commit that referenced this pull request Sep 11, 2023
* Fix sepa payment methods form ui
eurias-stripe added a commit that referenced this pull request Sep 12, 2023
* Add support for OXXO

* Update CHANGELOG.md

* Remove test

* Fix sepa payment method form ui (#7283)

* Fix sepa payment methods form ui

* Add support file

* Update CHANGELOG.md

---------

Co-authored-by: jameswoo-stripe <99316447+jameswoo-stripe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants