Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alma as a new payment method to Android PaymentSheet #7302

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

lisaliu-stripe
Copy link
Contributor

@lisaliu-stripe lisaliu-stripe commented Sep 13, 2023

Summary

Added Alma as a new payment method to Android PaymentSheet

Motivation

https://jira.corp.stripe.com/browse/THREEP_API-1035

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
Screenshot 2023-09-13 at 12 30 53 PM

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Sep 13, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.5 MiB │   3.5 MiB │   +331 B │   7.7 MiB │   7.7 MiB │   +188 B 
     arsc │   2.2 MiB │   2.2 MiB │   +748 B │   2.2 MiB │   2.2 MiB │   +748 B 
 manifest │   4.9 KiB │   4.9 KiB │      0 B │  24.2 KiB │  24.2 KiB │      0 B 
      res │ 881.2 KiB │ 884.7 KiB │ +3.6 KiB │   1.4 MiB │   1.4 MiB │ +7.2 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │    +78 B │     3 MiB │     3 MiB │   +728 B 
    other │ 199.9 KiB │ 200.1 KiB │   +178 B │ 447.9 KiB │ 448.2 KiB │   +328 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.3 MiB │  12.3 MiB │ +4.9 KiB │  20.7 MiB │  20.7 MiB │ +9.2 KiB 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 38331 │ 38333 │ +2 (+3 -1) 
   types │ 12692 │ 12692 │  0 (+0 -0) 
 classes │ 10716 │ 10716 │  0 (+0 -0) 
 methods │ 55936 │ 55936 │  0 (+0 -0) 
  fields │ 35249 │ 35250 │ +1 (+1 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  290 │  290 │  0         
 entries │ 6945 │ 6947 │ +2 (+2 -0)
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  2.3 KiB │ +2.3 KiB │     5 KiB │   +5 KiB │ + res/Xw.xml                  
  1.2 KiB │ +1.2 KiB │   2.2 KiB │ +2.2 KiB │ + res/JR.xml                  
  2.2 MiB │   +748 B │   2.2 MiB │   +748 B │ ∆ resources.arsc              
  3.5 MiB │   +331 B │   7.7 MiB │   +188 B │ ∆ classes.dex                 
 48.5 KiB │    +94 B │ 141.5 KiB │   +164 B │ ∆ META-INF/MANIFEST.MF        
   63 KiB │    +84 B │ 141.6 KiB │   +164 B │ ∆ META-INF/CERT.SF            
  2.9 KiB │    +81 B │    24 KiB │   +731 B │ ∆ assets/lpms.json            
  5.1 KiB │     -3 B │     5 KiB │     -3 B │ ∆ assets/dexopt/baseline.prof 
    999 B │     -3 B │   2.8 KiB │      0 B │ ∆ res/nn.xml                  
    839 B │     +1 B │   1.8 KiB │      0 B │ ∆ res/So.xml                  
    708 B │     -1 B │   1.3 KiB │      0 B │ ∆ res/UK.xml                  
    877 B │     +1 B │   2.3 KiB │      0 B │ ∆ res/YB.xml                  
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  5.8 MiB │ +4.9 KiB │  10.2 MiB │ +9.2 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   38331 │ 38333 │ +2 (+3 -1) 
  + Alma
  + alma
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:2a28311,r8-mode:full,version:8.1.65}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:0d2b784,r8-mode:full,version:8.1.65}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   35249 │ 35250 │ +1 (+1 -0) 
  + me.v A: u
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6945 │ 6947 │ +2 (+2 -0) 
  + drawable/stripe_ic_paymentsheet_pm_alma
  + string/stripe_paymentsheet_payment_method_alma

CHANGELOG.md Outdated
@@ -22,6 +22,7 @@
* [7269](https://github.com/stripe/stripe-android/pull/7269) iDEAL
* [7270](https://github.com/stripe/stripe-android/pull/7270) SEPA
* [7272](https://github.com/stripe/stripe-android/pull/7272) Sofort
* [7302](https://github.com/stripe/stripe-android/pull/7302) Alma
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this landed in the wrong release. Want to move it up to the most recent?

Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated
* [ADDED][7281](https://github.com/stripe/stripe-android/pull/7281) PaymentSheet now supports OXXO for PaymentIntents.
* [ADDED] PaymentSheet now supports the following payment methods for PaymentIntents:
* [7281](https://github.com/stripe/stripe-android/pull/7281) OXXO
* [7302](https://github.com/stripe/stripe-android/pull/7302) Alma
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is in a previous release again (sorry for the hotfix).

Can you bump this up and make it look something like

### PaymentSheet
* [ADDED][7302](https://github.com/stripe/stripe-android/pull/7302) PaymentSheet now supports Alma for PaymentIntents.

But now that I'm thinking about this, I'm not sure we want to do this if merchants need to be gated. Do we have a link where they can request an invitation to the beta?

@lisaliu-stripe lisaliu-stripe merged commit c7e1b62 into master Sep 13, 2023
10 checks passed
@lisaliu-stripe lisaliu-stripe deleted the lisaliu/alma-mobile branch September 13, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants