Fix issue where sepa mandate text is incorrectly being displayed #7303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
requested review from
tillh-stripe,
jaynewstrom-stripe and
samer-stripe
jameswoo-stripe
force-pushed
the
jameswoo/sepa-mandate-spec-fix
branch
from
83d77a9
to
f7463f5
Compare
samer-stripe
previously approved these changes
Sep 13, 2023
jameswoo-stripe
force-pushed
the
jameswoo/sepa-mandate-spec-fix
branch
from
f7463f5
to
cb049a5
Compare
eurias-stripe
previously approved these changes
Sep 13, 2023
jaynewstrom-stripe
previously approved these changes
Sep 13, 2023
samer-stripe
previously approved these changes
Sep 13, 2023
jameswoo-stripe
dismissed stale reviews from samer-stripe, jaynewstrom-stripe, and eurias-stripe
via
22db84a
jameswoo-stripe
force-pushed
the
jameswoo/sepa-mandate-spec-fix
branch
from
cb049a5
to
22db84a
Compare
jaynewstrom-stripe
approved these changes
Sep 13, 2023
samer-stripe
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue where sepa mandate text is incorrectly being displayed. The issue was that
PlaceholderField.SepaMandatecontained in thebillingDetailsPlaceholderslist was not being removed. It was added in there incorrectly in the first place. This code adds more fields that don't have a placeholder (the SEPA mandate placeholder in this case).Testing
Changelog