Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SI & PI w/ SFU support for Revolut Pay #7314

Merged
merged 3 commits into from
Sep 15, 2023

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Sep 14, 2023

Summary

Add SI & PI w/ SFU support for Revolut Pay

Motivation

More LPM support

Testing

  • Added tests
  • Modified tests
  • Manually verified

Changelog

[ADDED]7314 PaymentSheet now supports Revolut Pay for SetupIntents, and PaymentIntents with setup for future usage.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.5 MiB │   3.5 MiB │     -5 B │   7.7 MiB │   7.7 MiB │    +88 B 
     arsc │   2.2 MiB │   2.2 MiB │   +696 B │   2.2 MiB │   2.2 MiB │   +696 B 
 manifest │   4.9 KiB │   4.9 KiB │      0 B │  24.2 KiB │  24.2 KiB │      0 B 
      res │ 881.2 KiB │ 881.2 KiB │      0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │ -1.2 KiB │     3 MiB │     3 MiB │ -1.2 KiB 
    other │ 200.2 KiB │ 200.2 KiB │     +3 B │ 448.4 KiB │ 448.4 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.3 MiB │  12.3 MiB │   -552 B │  20.7 MiB │  20.7 MiB │   -462 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 38364 │ 38364 │  0 (+1 -1) 
   types │ 12703 │ 12703 │  0 (+0 -0) 
 classes │ 10724 │ 10724 │  0 (+0 -0) 
 methods │ 55967 │ 55968 │ +1 (+1 -0) 
  fields │ 35301 │ 35301 │  0 (+0 -0) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  290 │  290 │  0         
 entries │ 6950 │ 6951 │ +1 (+1 -0)
APK
     compressed      │     uncompressed     │                               
──────────┬──────────┼───────────┬──────────┤                               
 size     │ diff     │ size      │ diff     │ path                          
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  5.1 KiB │ -1.2 KiB │     5 KiB │ -1.2 KiB │ ∆ assets/dexopt/baseline.prof 
  2.2 MiB │   +696 B │   2.2 MiB │   +696 B │ ∆ resources.arsc              
  3.5 MiB │     -5 B │   7.7 MiB │    +88 B │ ∆ classes.dex                 
    837 B │     -1 B │   1.8 KiB │      0 B │ ∆ res/So.xml                  
    950 B │     +1 B │   2.5 KiB │      0 B │ ∆ res/de.xml                  
   63 KiB │     +1 B │ 141.6 KiB │      0 B │ ∆ META-INF/CERT.SF            
  1.2 KiB │     +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA           
 48.6 KiB │     +1 B │ 141.6 KiB │      0 B │ ∆ META-INF/MANIFEST.MF        
──────────┼──────────┼───────────┼──────────┼───────────────────────────────
  5.8 MiB │   -552 B │  10.2 MiB │   -462 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   38364 │ 38364 │ 0 (+1 -1) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:ef80bfc,r8-mode:full,version:8.1.65}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:de526c5,r8-mode:full,version:8.1.65}
  

METHODS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   55967 │ 55968 │ +1 (+1 -0) 
  + dg.v4 <init>(int)
ARSC
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6950 │ 6951 │ +1 (+1 -0) 
  + string/stripe_revolut_mandate

@samer-stripe samer-stripe enabled auto-merge (squash) September 15, 2023 18:21
@samer-stripe samer-stripe merged commit 7466a8a into master Sep 15, 2023
10 checks passed
@samer-stripe samer-stripe deleted the samer/support-revolut-pay-for-si-and-pi-with-sfu branch September 15, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants