Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin to 1.8.22 and Compose compiler to 1.4.8 #7409

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

carlosmuvi-stripe
Copy link
Collaborator

@carlosmuvi-stripe carlosmuvi-stripe commented Oct 6, 2023

Summary

  • Update Kotlin to 1.8.22
  • Compose to 1.4.8 (Version compatible with Kotlin 1.8.22)

@carlosmuvi-stripe carlosmuvi-stripe changed the title Update Kotlin to 1.8.22 and Compose to 1.4.8 Update Kotlin to 1.8.22 and Compose compiler to 1.4.8 Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.5 MiB │   3.5 MiB │   -603 B │   7.6 MiB │   7.6 MiB │ -7.1 KiB 
     arsc │   2.2 MiB │   2.2 MiB │      0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │     5 KiB │     5 KiB │      0 B │  24.9 KiB │  24.9 KiB │      0 B 
      res │ 898.7 KiB │ 898.7 KiB │      0 B │   1.3 MiB │   1.3 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │ +1.2 KiB │     3 MiB │     3 MiB │ +1.2 KiB 
    other │ 203.6 KiB │ 203.6 KiB │    -10 B │ 458.6 KiB │ 458.6 KiB │     +1 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.3 MiB │  12.3 MiB │   +629 B │  20.7 MiB │  20.7 MiB │ -5.8 KiB 

 DEX     │ old   │ new   │ diff               
─────────┼───────┼───────┼────────────────────
   files │     1 │     1 │    0               
 strings │ 38177 │ 38118 │  -59 (+81 -140)    
   types │ 12570 │ 12495 │  -75 (+63 -138)    
 classes │ 10577 │ 10501 │  -76 (+9 -85)      
 methods │ 55096 │ 54892 │ -204 (+4339 -4543) 
  fields │ 34982 │ 35045 │  +63 (+3557 -3494) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6908 │ 6908 │  0
APK
     compressed      │     uncompressed     │                                
──────────┬──────────┼───────────┬──────────┤                                
 size     │ diff     │ size      │ diff     │ path                           
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  6.4 KiB │ +1.2 KiB │   6.3 KiB │ +1.2 KiB │ ∆ assets/dexopt/baseline.prof  
  3.5 MiB │   -603 B │   7.6 MiB │ -7.1 KiB │ ∆ classes.dex                  
    786 B │    +11 B │     654 B │    +11 B │ ∆ assets/dexopt/baseline.profm 
 49.5 KiB │     -7 B │ 146.2 KiB │      0 B │ ∆ META-INF/MANIFEST.MF         
 65.2 KiB │     -4 B │ 146.3 KiB │      0 B │ ∆ META-INF/CERT.SF             
    412 B │     +2 B │     624 B │     +1 B │ ∆ kotlin-tooling-metadata.json 
  1.2 KiB │     -1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA            
──────────┼──────────┼───────────┼──────────┼────────────────────────────────
  3.6 MiB │   +629 B │   7.9 MiB │ -5.8 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   38177 │ 38118 │ -59 (+81 -140) 
  +  does not implement Parcelable or Serializable.
  +  does not implement Parcelable.
  +  does not implement Serializable.
  +  is an Enum. You should use EnumType instead.
  +  is not an Enum type.
  +  is not supported for navigation arguments.
  +  not found for type 
  + _this_navArgument
  + <ScanFlowParameters:
  + Enum value 
  + Lkotlinx/coroutines/h2;
  + Lmg/t3;
  + Lmg/u3;
  + Ly4/l0;
  + Ly4/m0;
  + Ly4/n0;
  + Ly4/o0;
  + Ly4/p0;
  + Ly4/q0;
  + Object of type 
  + Parcelables don't support default values.
  + Serializables don't support default values.
  + [L
  + [Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/i;
  + [Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/m;
  + [Lda/i;
  + [Lhg/b3;
  + [Lhg/c2;
  + [Lhg/w2;
  + [Ljava/io/Serializable;
  + [Ljd/a2;
  + [Ljd/b2;
  + [Ljd/c3;
  + [Ljd/d3;
  + [Ljd/e3;
  + [Ljd/g2;
  + [Ljd/j1;
  + [Ljd/j2;
  + [Ljd/k1;
  + [Ljd/o1;
  + [Ljd/p0;
  + [Ljd/p1;
  + [Ljd/r0;
  + [Ljd/x1;
  + [Ljd/x2;
  + [Ljd/y2;
  + [Lk2/h;
  + [Lk2/k;
  + [Lk2/n0;
  + [Lk2/u;
  + [Lkotlinx/coroutines/g0;
  + [Lkotlinx/coroutines/t0;
  + [Lkotlinx/coroutines/z1;
  + [Lme/k;
  + [Lmg/d3;
  + [Lmg/f3;
  + [Lmg/h2;
  + [Lmg/j1;
  + [Lmg/q1;
  + [Lmg/s3;
  + [Lmg/t2;
  + [Lmg/u1;
  + [Lmg/y0;
  + [Lob/f;
  + [Ltd/r0;
  + [Luc/o5;
  + [Luc/q5;
  + [Lvh/q;
  + [Ly4/l;
  + [Ly4/o0;
  + [Ly4/u;
  + [Lzb/l;
  + [Lzf/d4;
  + [Lzf/l7;
  + [Lzf/o3;
  + [Lzf/o4;
  + [Lzf/u5;
  + null cannot be cast to non-null type java.lang.Class<android.os.Parcelable>
  + null cannot be cast to non-null type java.lang.Class<java.io.Serializable>
  + type.enumConstants
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:41d76f1,r8-mode:full,version:8.1.65}
  
  - Lbb/e0;
  - Lbb/f0;
  - Lbb/g0;
  - Lcb/m;
  - Lcom/stripe/android/financialconnections/ui/x;
  - Lcom/stripe/android/financialconnections/ui/y;
  - Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/b0;
  - Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/c0;
  - Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/d0;
  - Lda/x;
  - Ldb/m;
  - Ldb/n;
  - Leb/s;
  - Leb/t;
  - Lee/h;
  - Lee/i;
  - Lfb/d0;
  - Lfb/e0;
  - Lgb/o;
  - Lgb/p;
  - Lhb/r;
  - Lhb/s;
  - Lhb/t;
  - Lhg/o4;
  - Lhg/p4;
  - Lhg/q4;
  - Lhg/r4;
  - Lib/q;
  - Lib/r;
  - Lib/s;
  - Lib/t;
  - Ljb/o;
  - Ljb/p;
  - Ljb/q;
  - Ljb/r;
  - Ljb/s;
  - Ljb/t;
  - Ljb/u;
  - Ljb/v;
  - Ljd/a4;
  - Ljd/y3;
  - Ljd/z3;
  - Lk2/q0;
  - Lkb/f;
  - Llb/o;
  - Llb/p;
  - Llg/q;
  - Llg/r;
  - Lmb/p;
  - Lmb/q;
  - Lmb/r;
  - Lme/d0;
  - Lnb/k;
  - Lnb/l;
  - Lnb/m;
  - Lnb/n;
  - Lnb/o;
  - Lob/x;
  - Lob/y;
  - Loc/x;
  - Loc/y;
  - Lpb/c;
  - Lpb/d;
  - Lqb/r;
  - Lqb/s;
  - Lqb/t;
  - Lqb/u;
  - Lqb/v;
  - Lqb/w;
  - Lqb/x;
  - Lqb/y;
  - Lqb/z;
  - Lrd/q;
  - Lre/b1;
  - Lre/c1;
  - Ltd/s0;
  - Lub/a0;
  - Lvh/g0;
  - Lxf/q;
  - Lzb/q;
  - Lzb/r;
  - Lzd/i0;
  - Lzf/s7;
  - Lzf/t7;
  - Lzf/u7;
  - [Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/l;
  - [Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/p;
  - [Lda/j;
  - [Lhg/d2;
  - [Lhg/f3;
  - [Lhg/x2;
  - [Ljd/a3;
  - [Ljd/b3;
  - [Ljd/e2;
  - [Ljd/f3;
  - [Ljd/g3;
  - [Ljd/h2;
  - [Ljd/h3;
  - [Ljd/l1;
  - [Ljd/m1;
  - [Ljd/p2;
  - [Ljd/q0;
  - [Ljd/q2;
  - [Ljd/u0;
  - [Ljd/v1;
  - [Ljd/y1;
  - [Ljd/z1;
  - [Lk2/i;
  - [Lk2/l;
  - [Lk2/o0;
  - [Lk2/v;
  - [Lkotlinx/coroutines/f0;
  - [Lkotlinx/coroutines/s0;
  - [Lkotlinx/coroutines/y1;
  - [Lme/o;
  - [Lmg/c3;
  - [Lmg/e3;
  - [Lmg/f2;
  - [Lmg/i1;
  - [Lmg/p1;
  - [Lmg/q3;
  - [Lmg/r2;
  - [Lmg/t1;
  - [Lmg/x0;
  - [Lob/h;
  - [Ltd/s0;
  - [Luc/p5;
  - [Luc/r5;
  - [Lvh/r;
  - [Ly4/i0;
  - [Ly4/j;
  - [Ly4/t;
  - [Lzb/n;
  - [Lzf/e4;
  - [Lzf/o7;
  - [Lzf/p3;
  - [Lzf/p4;
  - [Lzf/w5;
  - serialDesc
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:01aa2d2,r8-mode:full,version:8.1.65}
  

TYPES:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   12570 │ 12495 │ -75 (+63 -138) 
  + Lkotlinx/coroutines/h2;
  + Lmg/t3;
  + Lmg/u3;
  + Ly4/l0;
  + Ly4/m0;
  + Ly4/n0;
  + Ly4/o0;
  + Ly4/p0;
  + Ly4/q0;
  + [Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/i;
  + [Lcom/stripe/android/paymentsheet/paymentdatacollection/po
...✂

Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you need a ./gradlew apiDump

Should we also add this to the changelog? It's just a patch bump, but better to mention than not for these I think.

@carlosmuvi-stripe carlosmuvi-stripe marked this pull request as ready for review October 6, 2023 16:49
@carlosmuvi-stripe carlosmuvi-stripe requested review from a team as code owners October 6, 2023 16:49
@carlosmuvi-stripe carlosmuvi-stripe merged commit e58fe10 into master Oct 6, 2023
16 checks passed
@carlosmuvi-stripe carlosmuvi-stripe deleted the carlosmuvi/update-kotlin_1.8.22 branch October 6, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants