Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter saved cards originating from a wallet when showing saved payment methods. #7529

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented Oct 27, 2023

Summary

Hide Apple/Google Pay saved cards in PaymentSheet.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-1089

stripe/stripe-ios#3027

Testing

See unit test.

Changelog

  • [Fixed] PaymentSheet no longer displays saved cards that originated from Apple Pay or Google Pay.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.5 MiB │   3.5 MiB │ +239 B │   7.7 MiB │   7.7 MiB │ +728 B 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │    0 B 
 manifest │   5.1 KiB │   5.1 KiB │    0 B │  25.4 KiB │  25.4 KiB │    0 B 
      res │ 900.8 KiB │ 900.8 KiB │    0 B │   1.3 MiB │   1.3 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │     3 MiB │     3 MiB │  +18 B │     3 MiB │     3 MiB │  +18 B 
    other │ 204.2 KiB │ 204.2 KiB │  -13 B │ 459.7 KiB │ 459.7 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.4 MiB │  12.4 MiB │ +244 B │  20.8 MiB │  20.8 MiB │ +746 B 

 DEX     │ old   │ new   │ diff            
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0             
 strings │ 38480 │ 38483 │  +3 (+12 -9)    
   types │ 12638 │ 12639 │  +1 (+9 -8)     
 classes │ 10624 │ 10624 │   0 (+3 -3)     
 methods │ 55363 │ 55366 │  +3 (+875 -872) 
  fields │ 35563 │ 35573 │ +10 (+481 -471) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 6930 │ 6930 │  0
APK
    compressed     │    uncompressed    │                                
──────────┬────────┼───────────┬────────┤                                
 size     │ diff   │ size      │ diff   │ path                           
──────────┼────────┼───────────┼────────┼────────────────────────────────
  3.5 MiB │ +239 B │   7.7 MiB │ +728 B │ ∆ classes.dex                  
  6.4 KiB │  +17 B │   6.2 KiB │  +17 B │ ∆ assets/dexopt/baseline.prof  
 49.7 KiB │  -12 B │ 146.7 KiB │    0 B │ ∆ META-INF/MANIFEST.MF         
 65.4 KiB │   -3 B │ 146.8 KiB │    0 B │ ∆ META-INF/CERT.SF             
  1.2 KiB │   +2 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA            
    776 B │   +1 B │     644 B │   +1 B │ ∆ assets/dexopt/baseline.profm 
──────────┼────────┼───────────┼────────┼────────────────────────────────
  3.7 MiB │ +244 B │     8 MiB │ +746 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff        
  ───────┼───────┼─────────────
   38480 │ 38483 │ +3 (+12 -9) 
  + AmexExpressCheckout
  + Lbd/h;
  + Ldg/q;
  + Lk3/n;
  + SamsungPay
  + [Lbd/g;
  + [Ldf/v;
  + [Lk3/k;
  + [Lk3/m;
  + [Lq0/g0;
  + [Lzc/v5;
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:4782901,r8-mode:full,version:8.1.65}
  
  - Ldf/w;
  - Lk/j0;
  - Lzc/x5;
  - [Ldf/w;
  - [Lk3/j;
  - [Lk3/l;
  - [Lq0/h0;
  - [Lzc/x5;
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:f329757,r8-mode:full,version:8.1.65}
  

TYPES:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   12638 │ 12639 │ +1 (+9 -8) 
  + Lbd/h;
  + Ldg/q;
  + Lk3/n;
  + [Lbd/g;
  + [Ldf/v;
  + [Lk3/k;
  + [Lk3/m;
  + [Lq0/g0;
  + [Lzc/v5;
  
  - Ldf/w;
  - Lk/j0;
  - Lzc/x5;
  - [Ldf/w;
  - [Lk3/j;
  - [Lk3/l;
  - [Lq0/h0;
  - [Lzc/x5;
  

METHODS:

   old   │ new   │ diff           
  ───────┼───────┼────────────────
   55363 │ 55366 │ +3 (+875 -872) 
  + a0.p Y0(e, c, r, l) → SpannableString
  + a1.a a(long, k, c) → b
  + a1.a c(long, float, float, float, float, k) → b
  + a1.b a(long, c) → float
  + a1.c a(long, c) → float
  + a1.d c(long, float, float, float, float, k) → b
  + a1.e a(long, c) → float
  + a1.f a(long, c) → float
  + a1.g a(long, c) → float
  + a1.h c(long, float, float, float, float, k) → b
  + a2.e <init>(h, g, p0, h, LinkedHashMap)
  + a2.f K(int) → String
  + a2.f L(int) → String
  + a2.f M(String) → int
  + a2.f l(int) → long
  + a7.b A1(g) → h
  + a7.b F1(g) → h
  + a7.b p0(s1, float, l, d) → Object
  + a7.b x(long, long) → i
  + androidx.activity.y a(k)
  + androidx.appcompat.widget.a0 <init>(f, h0)
  + androidx.appcompat.widget.h4 d(i0) → boolean
  + androidx.appcompat.widget.h <init>(m, Context, i0, View)
  + androidx.appcompat.widget.m d(i0) → boolean
  + androidx.appcompat.widget.w <init>(h0)
  + androidx.compose.foundation.gestures.DraggableElement <init>(p0, r1, z0, boolean, m, a, f, f, boolean)
  + androidx.compose.foundation.layout.a g(u0, k) → float
  + androidx.compose.foundation.layout.a h(u0, k) → float
  + androidx.compose.foundation.lazy.AnimateItemPlacementElement <init>(a0)
  + androidx.compose.ui.node.a W(c)
  + androidx.compose.ui.platform.AndroidComposeView getDensity() → c
  + androidx.compose.ui.platform.AndroidComposeView getLayoutDirection() → k
  + androidx.compose.ui.platform.AndroidComposeView setLayoutDirection(k)
  + androidx.compose.ui.platform.a2 <init>(AndroidComposeView, c, h0)
  + androidx.compose.ui.platform.a2 g(float, float, float, float, float, float, float, float, float, float, long, l0, boolean, long, long, int, k, c)
  + androidx.compose.ui.platform.a2 i(h0, c)
  + androidx.compose.ui.platform.p2 <init>(AndroidComposeView, j1, c, h0)
  + androidx.compose.ui.platform.p2 g(float, float, float, float, float, float, float, float, float, float, long, l0, boolean, long, long, int, k, c)
  + androidx.compose.ui.platform.p2 i(h0, c)
  + androidx.compose.ui.platform.v1 <init>(c)
  + androidx.compose.ui.platform.v1 d(l0, float, boolean, float, k, c) → boolean
  + b.d <init>(l, a, o, String, k)
  + b0.g Q(b, v, h0, c, z0, d) → Serializable
  + b1.e2 <init>(k, c, r, c0, Object)
  + b1.j1 q0(c0, k) → c0
  + b1.k1 <init>(e, c0, int, int, boolean, int, c, r, List)
  + b1.k1 a(k)
  + b1.k2 <init>(d2, int, k0, h0)
  + b1.p1 d(p0)
  + b1.r0 <init>(d2, int, k0, h0)
  + b1.r1 a(c0, c, r, String, int) → long
  + b1.v0 <init>(float, float, q)
  + b1.v0 <init>(b0)
  + b1.v0 g(int) → b0
  + b1.v <init>(f2, c, c0, p, c, int)
  + b1.w <init>(v, f2, boolean, boolean, c, c0, p, c, int)
  + b1.x <init>(f2, c0, int, int, d2, c0, m0, n, n, n, n, d, v, boolean, boolean, c, p, c)
  + b1.y <init>(f, int, f2, c0, int, int, d2, c0, m0, n, n, n, n, d, v, boolean, boolean, c, p, c)
  + bd.f <init>(String, int, String)
  + bd.f valueOf(String) → f
  + bd.f values() → f[]
  + bd.g <clinit>()
  + bd.g <init>(c, String, String, c, String)
  + bd.g describeContents() → int
  + bd.g equals(Object) → boolean
  + bd.g hashCode() → int
  + bd.g toString() → String
  + bd.g writeToParcel(Parcel, int)
  + bd.h <init>(f)
  + bf.b a(String, String, v5, i, k) → Object
  + bf.b c(String, Locale, v5, l0, String, i, n) → Object
  + c1.b <init>(k, c0, c, r)
  + c1.d a(int, k) → int
  + c1.d b(long, k) → i
  + c1.d c(k) → k
  + c1.e a(int, k) → int
  + c1.e b(long, k) → a
  + c1.e d(k) → n
  + c1.f H
...✂

@jaynewstrom-stripe jaynewstrom-stripe merged commit eea13db into master Oct 27, 2023
10 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/filter-saved-apple-pay-cards branch October 27, 2023 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants