Fix issue where FC + PI would not launch ach collection flow #7545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameswoo-stripe
requested review from
tillh-stripe,
jaynewstrom-stripe and
samer-stripe
jameswoo-stripe
force-pushed
the
jameswoo/jameswoo/customersheet-payment-element-11
branch
from
fa4f5e4
to
287e858
Compare
| @@ -120,7 +121,7 @@ internal fun AddPaymentMethod( | |||
| usBankAccountFormArguments = USBankAccountFormArguments( | |||
| onBehalfOf = onBehalfOf, | |||
| isCompleteFlow = sheetViewModel is PaymentSheetViewModel, | |||
| isPaymentFlow = initializationMode is PaymentSheet.InitializationMode.PaymentIntent, | |||
| isPaymentFlow = stripeIntent.value is PaymentIntent, | |||
There was a problem hiding this comment.
Can you add a test for this?
jaynewstrom-stripe
approved these changes
Oct 31, 2023
|
No, since this is in a composable. I think we need to improve the business logic handling here. A lot of the business logic is contained in this composable. |
jameswoo-stripe
deleted the
jameswoo/jameswoo/customersheet-payment-element-11
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue where FC + PI would not launch ach collection flow
Testing
Changelog