Fix flow controller default payment method bug #7623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
requested review from
carlosmuvi-stripe,
tillh-stripe and
jaynewstrom-stripe
samer-stripe
commented
Nov 11, 2023
| @@ -292,7 +291,6 @@ internal class PaymentOptionsViewModel @Inject constructor( | |||
| } | |||
|
|
|||
| private fun processNewPaymentMethod(paymentSelection: PaymentSelection) { | |||
| prefsRepository.savePaymentSelection(paymentSelection) | |||
There was a problem hiding this comment.
Don't think we should be saving the selected option in PrefsRepository until after choosing to pay with it.
jaynewstrom-stripe
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
FlowControllerwhere the default payment method is not set properly after adding a new one and buying a product with it.Motivation
Ensures payment method is properly set as default after usage in payment.
Testing