Make CustomerSheet.Configuration non nullable. #7627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ import com.stripe.android.utils.rememberActivityOrNull | |||
| @ExperimentalCustomerSheetApi | |||
| @Composable | |||
| fun rememberCustomerSheet( | |||
| configuration: CustomerSheet.Configuration = CustomerSheet.Configuration(), | |||
| configuration: CustomerSheet.Configuration, | |||
There was a problem hiding this comment.
I’m not sure what to think about this. Should we relax this to a nullable config and create a default configuration internally, with the application label as the merchant name?
There was a problem hiding this comment.
Totally possible. This is what we do for PaymentSheet.
If everything else in this sounds good to you, I think we should definitely do that and ship it.
There was a problem hiding this comment.
Chatted offline. Slightly more inclined to leave it as not optional since the non compose way to instantiate CustomerSheet already requires a config.
jaynewstrom-stripe
force-pushed
the
jaynewstrom/non-null-customersheet-configuration
branch
from
b7e0545
to
f8444b5
Compare
tillh-stripe
approved these changes
Nov 17, 2023
jaynewstrom-stripe
deleted the
jaynewstrom/non-null-customersheet-configuration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make customer sheet configuration non null. This is to ensure defaults live in one place. Similar PR done in #7625