Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose and kotlin. #7718

Merged
merged 11 commits into from
Jan 31, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.6 MiB │   3.6 MiB │ +8.8 KiB │   7.8 MiB │   7.8 MiB │ +6.1 KiB 
     arsc │   2.4 MiB │   2.4 MiB │      0 B │   2.4 MiB │   2.4 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.4 KiB │  25.4 KiB │      0 B 
      res │ 928.6 KiB │ 928.6 KiB │      0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │     3 MiB │     3 MiB │   -117 B │     3 MiB │     3 MiB │   -117 B 
    other │ 205.6 KiB │ 205.6 KiB │    -65 B │ 462.8 KiB │ 462.8 KiB │    -52 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.6 MiB │  12.7 MiB │ +8.6 KiB │  21.1 MiB │  21.1 MiB │   +6 KiB 

 DEX     │ old   │ new   │ diff                 
─────────┼───────┼───────┼──────────────────────
   files │     1 │     1 │    0                 
 strings │ 39260 │ 39307 │  +47 (+1243 -1196)   
   types │ 13096 │ 13236 │ +140 (+840 -700)     
 classes │ 11059 │ 11141 │  +82 (+631 -549)     
 methods │ 54649 │ 54646 │   -3 (+16001 -16004) 
  fields │ 36259 │ 36508 │ +249 (+10081 -9832)  

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  327 │  327 │  0   
 entries │ 6953 │ 6953 │  0
APK
     compressed      │     uncompressed     │                                                   
──────────┬──────────┼───────────┬──────────┤                                                   
 size     │ diff     │ size      │ diff     │ path                                              
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────────────
  3.6 MiB │ +8.8 KiB │   7.8 MiB │ +6.1 KiB │ ∆ classes.dex                                     
          │   -177 B │           │     -5 B │ - META-INF/services/kotlinx.coroutines.internal.q 
          │   -161 B │           │     -5 B │ - META-INF/services/kotlinx.coroutines.b0         
    129 B │   +129 B │       5 B │     +5 B │ + META-INF/services/uh.a0                         
    127 B │   +127 B │       5 B │     +5 B │ + META-INF/services/zh.n                          
  6.6 KiB │   -125 B │   6.5 KiB │   -125 B │ ∆ assets/dexopt/baseline.prof                     
  1.4 KiB │    +20 B │   2.4 KiB │    +30 B │ ∆ kotlin/reflect/reflect.kotlin_builtins          
 50.5 KiB │    -14 B │ 148.3 KiB │    -41 B │ ∆ META-INF/MANIFEST.MF                            
 66.2 KiB │    +10 B │ 148.4 KiB │    -41 B │ ∆ META-INF/CERT.SF                                
    843 B │     +8 B │     711 B │     +8 B │ ∆ assets/dexopt/baseline.profm                    
  1.2 KiB │     +1 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                               
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────────────
  3.7 MiB │ +8.6 KiB │   8.1 MiB │   +6 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   39260 │ 39307 │ +47 (+1243 -1196) 
  +  in numeric literal
  +  is already one of the names for 
  +  is expected
  +  is not an Int
  +  is not found
  +  to Long
  + _ENTRIES
  + _args
  + _callback
  + _editButtonTypeface
  + _onChallengeResult
  + _paymentData
  + ' exists and serializer is registered in a corresponding SerializersModule.
  To be registered automatically, class '
  + ' for 
  + ' has to be sealed and '@Serializable'.
  + ' is not found 
  + ' should be quoted.
  Use 'isLenient = true' in 'Json {}' builder to accept non-compliant JSON.
  + ' value
  + ),
  + , allowTrailingComma=
  + , but 
  + , namingStrategy=null, decodeEnumsCaseInsensitive=
  + , should be >=0
  + ,owner=
  + .
  Check if class with serial name '
  + <get-onBackPressedDispatcher>(...)
  + <get-values>(...)
  + A3
  + Add
  + AddFpx
  + Another handler is already registered: 
  + B3
  + BUFFERED
  + Buffered channel capacity must be at least 1, but 
  + C3
  + CHANNEL_CLOSED
  + CLOSE_HANDLER_CLOSED
  + CLOSE_HANDLER_INVOKED
  + CODE_INVALID
  + CONNECTIONS_CONSENT_COMBINED_LOGO
  + CONNECTIONS_MOBILE_NATIVE
  + Can't convert 
  + Cannot read Json element because of unexpected 
  + Cannot use select clauses on the same object: 
  + ChallengeAdditionalAuth
  + ChallengeDecoupledAuth
  + Channel was cancelled
  + Class discriminator was missing and no default serializers were registered 
  + Clause with object 
  + Cordova
  + CreateAttach
  + CreditCard
  + CustomTabs
  + D3
  + DONE_RCV
  + E3
  + EB(
  + EMAIL_CODE_EXPIRED
  + Edit
  + F3
  + Failed to parse literal as '
  + Fill
  + Flutter
  + Form
  + G3
  + H3
  + I3
  + ILILJLZ
  + ILLILJLZ
  + INTERRUPTED_RCV
  + INTERRUPTED_SEND
  + IncorrectSelection
  + InformationOnly
  + Invalid channel capacity: 
  + J3
  + Json
  + K3
  + L3
  + LIST
  + LLCL
  + LLIJL
  + LLLLLII
  + LLZI
  + Lad/i0;
  + Lad/j0;
  + Lad/k0;
  + Lad/l0;
  + Lak/a;
  + Lak/b;
  + Landroidx/lifecycle/z1;
  + Lcd/v0;
  + Lcj/b;
  + Lcj/c;
  + Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/d0;
  + Lcom/stripe/android/paymentsheet/paymentdatacollection/polling/e0;
  + Ldb/r1;
  + Ldd/t;
  + Ldh/b;
  + Lea/h;
  + Lei/c;
  + Lei/d;
  + Lei/e;
  + Lei/f;
  + Lei/g;
  + Lei/h;
  + Lei/i;
  + Lej/e;
  + Lej/f;
  + Lej/g;
  + Lej/h;
  + Lej/i;
  + Lej/j;
  + Lej/k;
  + Lej/l;
  + Lej/m;
  + Lej/n;
  + Lfa/c0;
  + Lfi/b;
  + Lfi/c;
  + Lfi/d;
  + Lfi/e;
  + Lfi/f;
  + Lfi/g;
  + Lfi/h;
  + Lfi/i;
  + Lfi/j;
  + Lfi/k;
  + Lfi/l;
  + Lfi/m;
  + Lfi/n;
  + Lfi/o;
  + Lfi/p;
  + Lg1/t8;
  + Lg1/u8;
  + Lg1/v8;
  + Lga/a0;
  + Lgc/h;
  + Lgj/b;
  + Lgj/c;
  + Lgj/d;
  + Lgj/e;
  + Lhc/l;
  + Lhc/m;
  + Lhc/n;
  + Lhi/a0;
  + Lhi/a1;
  + Lhi/b0;
  + Lhi/b1;
  + Lhi/b;
  + Lhi/c0;
  + Lhi/c1;
  + Lhi/c;
  + Lhi/d0;
  + Lhi/d1;
  + Lhi/d;
  + Lhi/e0;
  + Lhi/e1;
  + Lhi/e;
  + Lhi/f0;
  + Lhi/f1;
  + Lhi/f;
  + Lhi/g0;
  + Lhi/g1;
  + Lhi/g;
  + Lhi/h0;
  + Lhi/h1;
  + Lhi/h;
  + Lhi/i0;
  + Lhi/i1;
  + Lhi/i;
  + Lhi/j0;
  + Lhi/j1;
  + Lhi/j;
  + Lhi/k0;
  + Lhi/k1;
  + Lhi/k;
  + Lhi/l0;
  + Lhi/l1;
  + Lhi/l;
  + Lhi/m0;
  + Lhi/m1;
  + Lhi/m;
  + Lhi/n0;
  + Lhi/n1;
  + Lhi/n;
  + Lhi/o0;
  + Lhi/o1;
  + Lhi/o;
  + Lhi/p0;
  + Lhi/p1;
  + Lhi/p;
  + Lhi/q0;
  + Lhi/q1;
  + Lhi/q;
  + Lhi/r0;
  + Lhi/r1;
  + Lhi/r;
  + Lhi/s0;
  + Lhi/s1;
  + Lhi/s;
  + Lhi/t0;
  + Lhi/t1;
  + Lhi/t;
  + Lhi/u0;
  + Lhi/u;
  + Lhi/v0;
  + Lhi/v;
  + Lhi/w0;
  + Lhi/w;
  + Lhi/x0;
  + Lhi/x;
  + Lhi/y0;
  + Lhi/y;
  + Lhi/z0;
  + Lhi/z;
  + Lia/b;
  + Lic/q0;
  + Lic/r0;
  + Lic/s0;
  + Lic/t0;
  + Lif/n1;
  + Lif/o1;
  + Lig/l;
  + Lii/a0;
  + Lii/b0;
  + Lii/b;
  + Lii/c0;
  + Lii/c;
  + Lii/d0;
  + Lii/d;
  + Lii/e0;
  + Lii/e;
  + Lii/f0;
  + Lii/f;
  + Lii/g0;
  + Lii/g;
  + Lii/h0;
  + Lii/h;
  + Lii/i;
  + Lii/j;
  + Lii/k;
  + Lii/l;
  + Lii/m;
  + Lii/n;
  + Lii/o;
  + Lii/p;
  + Lii/q;
  + Lii/r;
  + Lii/s;
  + Lii/t;
  + Lii/u;
  + Lii/v;
  + Lii/w;
  + Lii/x;
  + Lii/y;
  + Lii/z;
  + Ljd/p;
  + Ljd/q;
  + Lje/j;
  + Lje/k;
  + Ljh/f;
  + Ljh/g;
  + Ljh/h;
  + Ljh/i;
  + Ljh/j;
  + Ljh/k;
  + Ljh/l;
  + Ljh/m;
  + Ljh/n;
  + Ljh/o;
  + Ljh/p;
  + Ljh/q;
  + Ljh/r;
  + Ljh/s;
  + Ljh/t;
  + Ljh/u;
  + Ljh/v;
  + Ljh/w;
  + Ljh/x;
  + Lji/a0;
  + Lji/b0;
  + Lji/b;
  + Lji/c0;
  + Lji/c;
  + Lji/d0;
  + Lji/d;
  + Lji/e0;
  + Lji/e;
  + Lji/f0;
  + Lji/f;
  + Lji/g;
  + Lji/h;
  + Lji/i;
  + Lji/j;
  + Lji/k;
  + Lji
...✂

kotlinCoroutines : '1.6.4',
kotlinSerialization : '1.5.0',
kotlin : '1.9.21',
kotlinCoroutines : '1.7.3',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update playServices to the same version.

@@ -31,11 +31,9 @@ abstract class PaymentAuthenticator<Authenticatable> : ActivityResultLauncherHos
requestOptions: ApiRequest.Options
) {
val lifecycleOwner = host.lifecycleOwner
lifecycleOwner.lifecycleScope.launch {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This behavior change might not be intentional.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave this a quick test run and it seems to work fine when running in the existing scope.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same! I also ran through the code to make sure it was logical. But I think this was really the only "change", so figured I'd call it out.

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review January 31, 2024 01:48
@jaynewstrom-stripe
Copy link
Collaborator Author

Changes LGTM, since both Till and I contributed here.

@jaynewstrom-stripe
Copy link
Collaborator Author

LGTM!

@jaynewstrom-stripe jaynewstrom-stripe enabled auto-merge (squash) January 31, 2024 14:15
@jaynewstrom-stripe jaynewstrom-stripe merged commit a1577a2 into master Jan 31, 2024
16 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/kotlin-compose-upgrade branch January 31, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants