Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Reset scanner state when disposed #7757

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Conversation

ccen-stripe
Copy link
Collaborator

@ccen-stripe ccen-stripe commented Jan 6, 2024

Summary

Add a function to reset scanner state to Initializing when the compose view is disposed.

Motivation

This ensures the view would restart from a fresh state and avoid a crash when selfie is retried.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │          uncompressed          
          ├───────────┬───────────┬───────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff   
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
      dex │   1.9 MiB │   1.9 MiB │  +9 B │     4 MiB │     4 MiB │ +124 B 
     arsc │   1.4 MiB │   1.4 MiB │   0 B │   1.4 MiB │   1.4 MiB │    0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │   8.1 KiB │   8.1 KiB │    0 B 
      res │ 353.2 KiB │ 353.2 KiB │   0 B │ 485.2 KiB │ 485.2 KiB │    0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │    0 B 
    asset │  67.7 KiB │  67.7 KiB │   0 B │  87.7 KiB │  87.7 KiB │    0 B 
    other │ 113.4 KiB │ 113.4 KiB │  +2 B │ 261.2 KiB │ 261.2 KiB │    0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼────────
    total │    10 MiB │    10 MiB │ +11 B │  21.9 MiB │  21.9 MiB │ +124 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 20254 │ 20254 │ 0 (+1 -1) 
   types │  6302 │  6302 │ 0 (+0 -0) 
 classes │  5158 │  5158 │ 0 (+0 -0) 
 methods │ 29628 │ 29628 │ 0 (+0 -0) 
  fields │ 17240 │ 17240 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  261 │  261 │  0   
 entries │ 5190 │ 5190 │  0
APK
    compressed    │    uncompressed    │                        
──────────┬───────┼───────────┬────────┤                        
 size     │ diff  │ size      │ diff   │ path                   
──────────┼───────┼───────────┼────────┼────────────────────────
  1.9 MiB │  +9 B │     4 MiB │ +124 B │ ∆ classes.dex          
 49.7 KiB │  +3 B │ 113.5 KiB │    0 B │ ∆ META-INF/CERT.SF     
 31.4 KiB │  -2 B │ 113.4 KiB │    0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │  +1 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA    
──────────┼───────┼───────────┼────────┼────────────────────────
    2 MiB │ +11 B │   4.2 MiB │ +124 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   20254 │ 20254 │ 0 (+1 -1) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:05ef1b5,r8-mode:full,version:8.2.33}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:befbfa8,r8-mode:full,version:8.2.33}

@ccen-stripe
Copy link
Collaborator Author

@stripe/stripe-identity-observers

@ccen-stripe ccen-stripe merged commit 57a84d6 into master Jan 8, 2024
12 checks passed
@ccen-stripe ccen-stripe deleted the ccen/selfieCrash branch January 8, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants