Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make document scan screen's viewFinder square #7903

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

ccen-stripe
Copy link
Collaborator

Summary

This is a pre change to an upcoming UX overhaul(link), also it fixes black screen camera on some devices(thread)

Motivation

Bug fix and new UX

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before_scanning after_scanning
before_done after_done

Changelog

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed          
          ├───────────┬───────────┬──────┼───────────┬───────────┬───────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff  
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼───────
      dex │     2 MiB │     2 MiB │ +1 B │   4.1 MiB │   4.1 MiB │ -88 B 
     arsc │   1.4 MiB │   1.4 MiB │  0 B │   1.4 MiB │   1.4 MiB │   0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │   0 B 
      res │ 363.2 KiB │ 363.2 KiB │  0 B │ 490.6 KiB │ 490.6 KiB │   0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │   0 B 
    asset │  67.8 KiB │  67.8 KiB │ +1 B │  87.8 KiB │  87.8 KiB │  +1 B 
    other │ 114.7 KiB │ 114.7 KiB │ -1 B │ 270.3 KiB │ 270.3 KiB │   0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼───────
    total │  10.2 MiB │  10.2 MiB │ +1 B │  22.2 MiB │  22.2 MiB │ -87 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 20871 │ 20869 │ -2 (+1 -3) 
   types │  6490 │  6490 │  0 (+0 -0) 
 classes │  5280 │  5280 │  0 (+0 -0) 
 methods │ 30573 │ 30573 │  0 (+2 -2) 
  fields │ 17726 │ 17726 │  0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  262 │  262 │  0   
 entries │ 5504 │ 5504 │  0
APK
   compressed    │   uncompressed    │                               
──────────┬──────┼───────────┬───────┤                               
 size     │ diff │ size      │ diff  │ path                          
──────────┼──────┼───────────┼───────┼───────────────────────────────
 31.4 KiB │ -3 B │ 118.4 KiB │   0 B │ ∆ META-INF/MANIFEST.MF        
 51.5 KiB │ +2 B │ 118.4 KiB │   0 B │ ∆ META-INF/CERT.SF            
  5.9 KiB │ +1 B │   5.8 KiB │  +1 B │ ∆ assets/dexopt/baseline.prof 
    2 MiB │ +1 B │   4.1 MiB │ -88 B │ ∆ classes.dex                 
──────────┼──────┼───────────┼───────┼───────────────────────────────
  2.1 MiB │ +1 B │   4.3 MiB │ -87 B │ (total)
DEX
STRINGS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   20871 │ 20869 │ -2 (+1 -3) 
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:5837ba0,r8-mode:full,version:8.2.47}
  
  -  must be > 0
  - aspectRatio 
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:56e2889,r8-mode:full,version:8.2.47}
  

METHODS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   30573 │ 30573 │ 0 (+2 -2) 
  + androidx.compose.foundation.layout.AspectRatioElement <init>(boolean)
  + androidx.compose.foundation.layout.a f(o) → o
  
  - androidx.compose.foundation.layout.AspectRatioElement <init>(float, boolean)
  - androidx.compose.foundation.layout.a f(o, float) → o

@ccen-stripe ccen-stripe merged commit da5ac20 into master Feb 8, 2024
11 checks passed
@ccen-stripe ccen-stripe deleted the ccen/fixBlackcreen branch February 8, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants