Prevent AddSourceActivity's SourceCallback from being GCed #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** `Stripe#CreateSourceTask` holds a `WeakReference` to the `SourceCallback`. This reference was being garbage collected, causing callback (either onSuccess or onError) to never happen. Making the SourceCallback an instance variable seems to fix this issue. **Motivation** Because the callback was never happening, the user would be stuck on the "Add a Card" screen. **Testing** Tested manually on various API levels.
mshafrir-stripe
force-pushed
the
sourcecallback
branch
from
367919e
to
9c7c759
Compare
csabol-stripe
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Stripe#CreateSourceTaskholds aWeakReferenceto theSourceCallback. In some cases, this reference was beinggarbage collected, causing callback (either
onSuccess()oronError()) to never happen.Making the
SourceCallbackan instance variable seems to fixthis issue.
Motivation
Because the callback was never happening, the user would be
stuck on the "Add a Card" screen.
Testing
Tested manually on various API levels.