Make StripeSourceTypeModel public #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
force-pushed
the
stripe-source-type-model
branch
from
c941517
to
921ceee
Compare
**Summary** - Make `StripeSourceTypeModel` public - Clean up the internal structure of `StripeSourceTypeModel` **Motivation** `Source#getSourceTypeModel()` is a public method, but it returns a type (`StripeSourceTypeModel`) that is package-private, causing warnings in the IDE. This is a safe change, because the methods in `StripeSourceTypeModel` that should not be accessed publicly are still package-private. In addition, `StripeSourceTypeModel` extends `StripeJsonModel`, which itself is public. Fixes #616
mshafrir-stripe
force-pushed
the
stripe-source-type-model
branch
from
921ceee
to
bae7a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
StripeSourceTypeModelpublicStripeSourceTypeModelMotivation
Source#getSourceTypeModel()is a public method, but it returnsa type (
StripeSourceTypeModel) that is package-private, causingwarnings in the IDE. This is a safe change, because the methods in
StripeSourceTypeModelthat should not be accessed publicly arestill package-private. In addition,
StripeSourceTypeModelextendsStripeJsonModel, which itself is public.Fixes #616
Testing
Existing unit test coverage.