Fix TalkBack crash in CardInputWidget #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** `android:accessibilityTraversalAfter` on both the expiration date and CVC input views were pointing to the wrong views. **Testing** On a Google Pixel, confirmed that TalkBack is no longer crashing when navigating through the input views of CardInputWidget. **Motivation** Fixes #682
danwaters-stripe
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
android:accessibilityTraversalAfteron boththe expiration date and CVC input views were
pointing to the wrong views.
Motivation
Fixes #682
Testing
On a Google Pixel, confirmed that TalkBack is
no longer crashing when navigating through
the input views of CardInputWidget.