Correctly handle Cartes Bancaires test cards in retrievePossibleBrands #8258

amk-stripe · 2024-04-10T22:43:09Z

Summary

Return correct possible brands for Cartes Bancaires test cards in retrievePossibleBrands API

Motivation

Our API used to incorrectly return only Visa or only Mastercard for the two Cartes Bancaires multi-brand test cards, seen in our docs here

Testing

Added tests
Modified tests
Manually verified

Changelog

[FIXED]8259 Fixed an issue with retrievePossibleBrands returning incorrect brands for Cartes Bancaires test cards.

github-actions · 2024-04-10T22:49:23Z

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │   3.9 MiB │   3.9 MiB │ -231 B │   8.5 MiB │   8.5 MiB │ +148 B 
     arsc │   2.2 MiB │   2.2 MiB │    0 B │   2.2 MiB │   2.2 MiB │    0 B 
 manifest │     5 KiB │     5 KiB │    0 B │  24.9 KiB │  24.9 KiB │    0 B 
      res │ 911.1 KiB │ 911.1 KiB │    0 B │   1.4 MiB │   1.4 MiB │    0 B 
   native │   2.6 MiB │   2.6 MiB │    0 B │     6 MiB │     6 MiB │    0 B 
    asset │     3 MiB │     3 MiB │    0 B │     3 MiB │     3 MiB │    0 B 
    other │   204 KiB │   204 KiB │   +9 B │ 444.8 KiB │ 444.8 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  12.8 MiB │  12.8 MiB │ -222 B │  21.7 MiB │  21.7 MiB │ +148 B 

 DEX     │ old   │ new   │ diff       
─────────┼───────┼───────┼────────────
   files │     1 │     1 │  0         
 strings │ 42605 │ 42605 │  0 (+1 -1) 
   types │ 14495 │ 14495 │  0 (+0 -0) 
 classes │ 12223 │ 12223 │  0 (+0 -0) 
 methods │ 60396 │ 60396 │  0 (+0 -0) 
  fields │ 40086 │ 40087 │ +1 (+1 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6030 │ 6030 │  0

APK

    compressed     │    uncompressed    │                        
──────────┬────────┼───────────┬────────┤                        
 size     │ diff   │ size      │ diff   │ path                   
──────────┼────────┼───────────┼────────┼────────────────────────
  3.9 MiB │ -231 B │   8.5 MiB │ +148 B │ ∆ classes.dex          
   62 KiB │   +9 B │ 139.7 KiB │    0 B │ ∆ META-INF/CERT.SF     
  1.2 KiB │   -2 B │   1.2 KiB │    0 B │ ∆ META-INF/CERT.RSA    
 53.1 KiB │   +2 B │ 139.6 KiB │    0 B │ ∆ META-INF/MANIFEST.MF 
──────────┼────────┼───────────┼────────┼────────────────────────
    4 MiB │ -222 B │   8.8 MiB │ +148 B │ (total)

DEX

STRINGS:

   old   │ new   │ diff      
  ───────┼───────┼───────────
   42605 │ 42605 │ 0 (+1 -1) 
  
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:a0cfda6,r8-mode:full,version:8.3.37}
  
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:3c16195,r8-mode:full,version:8.3.37}
  

FIELDS:

   old   │ new   │ diff       
  ───────┼───────┼────────────
   40086 │ 40087 │ +1 (+1 -0) 
  
  + I4.v j: ArrayList

sfriedman-stripe · 2024-04-11T02:39:49Z

:sonic: 👏🏻

porter-stripe · 2024-04-11T03:50:14Z

payments-core/src/main/java/com/stripe/android/cards/DefaultStaticCardAccountRanges.kt

+        private val CARTES_BANCAIRES_ACCOUNT_RANGES = setOf(
+            BinRange(
+                low = "2221000000000000",
+                high = "2720000000000000"
+            ),
+            BinRange(
+                low = "4000000000000000",
+                high = "4999999999999999"
+            ),
+            BinRange(
+                low = "5000000000000000",
+                high = "5900000000000000"
+            ),
+            BinRange(
+                low = "6700000000000000",
+                high = "6799999999999999"
+            )
+        ).map {
+            AccountRange(
+                binRange = it,
+                panLength = 16,
+                brandInfo = AccountRange.BrandInfo.CartesBancaires
+            )
+        }


How do these bin ranges impact other cards besides the test cards? Is there any reason why we can't hardcode the test numbers rather than these ranges? In production the card metadata service determines what card brands to vend to the client, rather than have the client determine this. I'm concerned these bin ranges could have unintended consequences.

https://github.com/stripe/stripe-ios/blob/ac4a8468/StripePayments/StripePayments/Source/Helpers/STPCardValidator.swift#L444

https://github.com/stripe/stripe-android/blob/5e021d15/payments-core/src/main/java/com/stripe/android/cards/CbcTestCardDelegate.kt#L10

I do see failing tests relating to CBC and BIN in the bitrise run, I think we should hardcode these card numbers rather than have the test cards influence client side bin ranges.

Looks like StripeJS also hardcodes: https://git.corp.stripe.com/stripe-internal/stripe-js-v3/blob/4900dd4d/src/elements/inner/card/Bins.ts#L78

Sure, I can hardcode the test numbers. That seems good so that we can de-risk getting this fixed and to ensure we don't introduce any unintended behavior.

The BIN ranges that I added here match the regex that we use for CBC. This API and CBC don't actually use the same code path for determining possible brands. Created a jira to unify the two code paths because it seems less than ideal that this API would have different behavior than our implementation of CBC.

Updated PR to just add the test numbers and no other ranges

amk-stripe · 2024-04-11T18:05:24Z

payments-core/src/main/java/com/stripe/android/cards/CardAccountRangeService.kt

@@ -43,17 +43,6 @@ class CardAccountRangeService(
            return
        }

-        val testAccountRanges = if (isCbcEligible()) {


This was used to ensure that the test cards were handled properly in this service. Now the test cards are part of the static card ranges (queried below), so we don't need this special handling.

amk-stripe · 2024-04-11T18:06:21Z

payments-core/src/test/java/com/stripe/android/cards/CardAccountRangeServiceTest.kt

-            panLength = 16,
-            brandInfo = AccountRange.BrandInfo.Visa,
-        )
+    fun `If CBC is disabled and only one brand matches, return the matched brand as soon as there is input`() =


this test depends on there being only one card that matches the input. Now that the Cartes Bancaires test card also matches a "4" prefix, I needed to change the digit and card brand being used for this test

Add static Cartes Bancaires account ranges

cfc3b53

amk-stripe requested a review from samer-stripe April 10, 2024 22:43

amk-stripe requested review from a team as code owners April 10, 2024 22:43

Update CHANGELOG.md

27c14cd

amk-stripe enabled auto-merge (squash) April 10, 2024 22:45

jaynewstrom-stripe previously approved these changes Apr 10, 2024

View reviewed changes

porter-stripe reviewed Apr 11, 2024

View reviewed changes

only add test cards instead of full bin ranges

1ea91ad

amk-stripe dismissed jaynewstrom-stripe’s stale review via 1ea91ad April 11, 2024 17:58

amk-stripe added 2 commits April 11, 2024 11:00

Add comment about test cards

aadfac6

Remove CBC test card delegate

41d5667

amk-stripe commented Apr 11, 2024

View reviewed changes

samer-stripe previously approved these changes Apr 12, 2024

View reviewed changes

fix some tests

f0915b9

amk-stripe dismissed samer-stripe’s stale review via f0915b9 April 12, 2024 17:17

samer-stripe previously approved these changes Apr 12, 2024

View reviewed changes

change how we update the account ranges result

28bc73d

amk-stripe dismissed samer-stripe’s stale review via 28bc73d April 12, 2024 21:20

amk-stripe and others added 6 commits April 12, 2024 14:51

remove unused import

ee52366

wait for UI thread to update in CardDetailsControllerTest

d25bcad

try waiting for UI thread in CardDetailsElementTest

b8937f9

add back test card delegate

9865492

Merge branch 'master' into test-cards-in-retrieve-possible-brands

fa9b82b

fix CardNumberEditTextTest

723756c

samer-stripe approved these changes Apr 15, 2024

View reviewed changes

amk-stripe merged commit d6b0e23 into master Apr 15, 2024
15 checks passed

amk-stripe deleted the test-cards-in-retrieve-possible-brands branch April 15, 2024 17:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correctly handle Cartes Bancaires test cards in retrievePossibleBrands #8258

Correctly handle Cartes Bancaires test cards in retrievePossibleBrands #8258

amk-stripe commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited

sfriedman-stripe commented Apr 11, 2024

porter-stripe Apr 11, 2024 •

edited

porter-stripe Apr 11, 2024

porter-stripe Apr 11, 2024

amk-stripe Apr 11, 2024 •

edited

amk-stripe Apr 11, 2024

amk-stripe Apr 11, 2024

amk-stripe Apr 11, 2024

Correctly handle Cartes Bancaires test cards in retrievePossibleBrands #8258

Correctly handle Cartes Bancaires test cards in retrievePossibleBrands #8258

Conversation

amk-stripe commented Apr 10, 2024 • edited

Summary

Motivation

Testing

Changelog

github-actions bot commented Apr 10, 2024 • edited

sfriedman-stripe commented Apr 11, 2024

porter-stripe Apr 11, 2024 • edited

Choose a reason for hiding this comment

porter-stripe Apr 11, 2024

Choose a reason for hiding this comment

porter-stripe Apr 11, 2024

Choose a reason for hiding this comment

amk-stripe Apr 11, 2024 • edited

Choose a reason for hiding this comment

amk-stripe Apr 11, 2024

Choose a reason for hiding this comment

amk-stripe Apr 11, 2024

Choose a reason for hiding this comment

amk-stripe Apr 11, 2024

Choose a reason for hiding this comment

amk-stripe commented Apr 10, 2024 •

edited

github-actions bot commented Apr 10, 2024 •

edited

porter-stripe Apr 11, 2024 •

edited

amk-stripe Apr 11, 2024 •

edited