Refactor StripeApiHandler to use instance methods #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Make `StripeApiHandler` an instantiable class so that its dependencies can be injected via constructor instead of needing to be passed in through static methods. **Motivation** ANDROID-338
mshafrir-stripe
force-pushed
the
refactor-stripe-api-handler
branch
from
d419ae7
to
06f9470
Compare
danwaters-stripe
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make
StripeApiHandleran instantiable class so that itsdependencies can be injected via constructor instead of
needing to be passed in through static methods.
Motivation
ANDROID-338
Testing
Updated unit tests and test on device