-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test mode toggle and simplify playground logic #8416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
force-pushed
the
tillh/fc-playground-testmode
branch
from
May 3, 2024 18:47
dc6cbcb
to
f112167
Compare
tillh-stripe
force-pushed
the
tillh/fc-playground-testmode
branch
from
May 3, 2024 18:50
f112167
to
6b91b39
Compare
Diffuse output:
APK
|
tillh-stripe
requested review from
samer-stripe and
carlosmuvi-stripe
and removed request for
samer-stripe
May 3, 2024 19:58
carlosmuvi-stripe
approved these changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Comment on lines
+31
to
+33
override fun shouldDisplay(merchant: Merchant, flow: Flow): Boolean { | ||
return flow == Flow.PaymentIntent | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request simplifies some logic in the FC playground and adds a test mode toggle the merchant profiles (except the custom one). We’ll follow up with adding the ability to create and store custom merchant profiles.
Motivation
Testing
Screenshots
Changelog