Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor voucher Authenticators into a single VoucherAuthenticator type #8448

Merged
merged 4 commits into from
May 13, 2024
Merged

Refactor voucher Authenticators into a single VoucherAuthenticator type #8448

merged 4 commits into from
May 13, 2024

Commits on May 10, 2024

  1. Refactor voucher Authenticators into a single VoucherAuthenticator type 

    Whenever we add a voucher LPM, we currently have to create a new
Authenticator every time. However, we can instead make each piece of
next action data conform to a common DisplayVoucherDetails interface and
then delete all of the LPM-specific authenticators.
    @sfriedman-stripe
    sfriedman-stripe committed May 10, 2024
    Configuration menu
    Copy the full SHA
    60860fb View commit details
    Browse the repository at this point in the history

  2. Add back type info for errors

    @sfriedman-stripe
    sfriedman-stripe committed May 10, 2024
    Configuration menu
    Copy the full SHA
    85e89d0 View commit details
    Browse the repository at this point in the history

  3. Remove stray println

    @sfriedman-stripe
    sfriedman-stripe committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8fa2f8a View commit details
    Browse the repository at this point in the history

  4. Restrict DisplayVoucherDetails to library group

    @sfriedman-stripe
    sfriedman-stripe committed May 10, 2024
    Configuration menu
    Copy the full SHA
    ce4219a View commit details
    Browse the repository at this point in the history