-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CustomerSheet
playground UI
#8524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diffuse output:
APK
|
samer-stripe
force-pushed
the
samer/add-customer-sheet-playground-state-and-network-support
branch
2 times, most recently
from
May 23, 2024 17:31
1c419f9
to
6027909
Compare
Base automatically changed from
samer/add-customer-sheet-playground-state-and-network-support
to
master
May 23, 2024 21:17
samer-stripe
force-pushed
the
samer/customer-sheet-playground-ui
branch
from
May 23, 2024 21:25
993f71c
to
c79c564
Compare
samer-stripe
requested review from
tillh-stripe and
jaynewstrom-stripe
and removed request for
tillh-stripe
May 23, 2024 21:43
...in/java/com/stripe/android/paymentsheet/example/playground/PaymentSheetPlaygroundActivity.kt
Outdated
Show resolved
Hide resolved
...n/java/com/stripe/android/paymentsheet/example/playground/PaymentSheetPlaygroundViewModel.kt
Outdated
Show resolved
Hide resolved
@@ -101,6 +107,14 @@ internal class PaymentSheetPlaygroundActivity : AppCompatActivity(), ExternalPay | |||
|
|||
val playgroundState by viewModel.state.collectAsState() | |||
|
|||
val customerSheet = playgroundState?.asCustomerState()?.let { customerPlaygroundState -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want this to be unconditionally created like the others. Is that not possible with customer sheet? If not this integration shape is probably wrong :/
jaynewstrom-stripe
approved these changes
May 23, 2024
Approved to not block progress. But my last comment should probably have a follow up discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
CustomerSheet
playground UI to completeCustomerSheet
integration in the playground.Motivation
Allows for showing
CustomerSheet
integration in playground.Testing
Videos
Screen_recording_20240523_170151.mp4
Screen_recording_20240523_171642.mp4
1000004770.mp4