Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CustomerSheet playground UI #8524

Merged
merged 2 commits into from
May 23, 2024

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented May 23, 2024

Summary

Add CustomerSheet playground UI to complete CustomerSheet integration in the playground.

Motivation

Allows for showing CustomerSheet integration in playground.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Videos

1 2
Screen_recording_20240523_170151.mp4
Screen_recording_20240523_171642.mp4
1000004770.mp4

Copy link
Contributor

github-actions bot commented May 23, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.3 MiB │   4.3 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │   8.1 KiB │   8.1 KiB │  0 B 
      res │ 301.5 KiB │ 301.5 KiB │  0 B │   455 KiB │   455 KiB │  0 B 
   native │   7.3 MiB │   7.3 MiB │  0 B │  18.4 MiB │  18.4 MiB │  0 B 
    asset │   1.5 MiB │   1.5 MiB │  0 B │   1.5 MiB │   1.5 MiB │  0 B 
    other │    87 KiB │    87 KiB │ +9 B │ 161.5 KiB │ 161.5 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  12.2 MiB │  12.2 MiB │ +9 B │  25.8 MiB │  25.8 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 21688 │ 21688 │ 0 (+0 -0) 
   types │  6869 │  6869 │ 0 (+0 -0) 
 classes │  5634 │  5634 │ 0 (+0 -0) 
 methods │ 31448 │ 31448 │ 0 (+0 -0) 
  fields │ 18315 │ 18315 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3404 │ 3404 │  0
APK
   compressed    │   uncompressed   │                                           
──────────┬──────┼───────────┬──────┤                                           
 size     │ diff │ size      │ diff │ path                                      
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 25.9 KiB │ +3 B │  63.9 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
    272 B │ +2 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
 29.1 KiB │ +2 B │    64 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │ +2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────┼───────────┼──────┼───────────────────────────────────────────
 56.4 KiB │ +9 B │ 129.2 KiB │  0 B │ (total)

@samer-stripe samer-stripe force-pushed the samer/add-customer-sheet-playground-state-and-network-support branch 2 times, most recently from 1c419f9 to 6027909 Compare May 23, 2024 17:31
Base automatically changed from samer/add-customer-sheet-playground-state-and-network-support to master May 23, 2024 21:17
@samer-stripe samer-stripe force-pushed the samer/customer-sheet-playground-ui branch from 993f71c to c79c564 Compare May 23, 2024 21:25
@samer-stripe samer-stripe marked this pull request as ready for review May 23, 2024 21:43
@samer-stripe samer-stripe requested review from a team as code owners May 23, 2024 21:43
@samer-stripe samer-stripe requested review from tillh-stripe and jaynewstrom-stripe and removed request for tillh-stripe May 23, 2024 21:43
@@ -101,6 +107,14 @@ internal class PaymentSheetPlaygroundActivity : AppCompatActivity(), ExternalPay

val playgroundState by viewModel.state.collectAsState()

val customerSheet = playgroundState?.asCustomerState()?.let { customerPlaygroundState ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want this to be unconditionally created like the others. Is that not possible with customer sheet? If not this integration shape is probably wrong :/

@jaynewstrom-stripe
Copy link
Collaborator

Approved to not block progress. But my last comment should probably have a follow up discussion.

@samer-stripe samer-stripe enabled auto-merge (squash) May 23, 2024 23:16
@samer-stripe samer-stripe merged commit 33efc82 into master May 23, 2024
12 checks passed
@samer-stripe samer-stripe deleted the samer/customer-sheet-playground-ui branch May 23, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants