Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to card form in vertical mode. #8527

Merged
merged 2 commits into from
May 23, 2024

Conversation

jaynewstrom-stripe
Copy link
Collaborator

@jaynewstrom-stripe jaynewstrom-stripe commented May 23, 2024

Summary

Adds link inline signup to the card form.

Motivation

https://jira.corp.stripe.com/browse/MOBILESDK-2113

Copy link
Contributor

github-actions bot commented May 23, 2024

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │           uncompressed           
          ├───────────┬───────────┬──────────┼───────────┬───────────┬──────────
 APK      │ old       │ new       │ diff     │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
      dex │   3.9 MiB │   3.9 MiB │   +931 B │   8.6 MiB │   8.6 MiB │ +1.1 KiB 
     arsc │   2.2 MiB │   2.2 MiB │      0 B │   2.2 MiB │   2.2 MiB │      0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │  25.8 KiB │  25.8 KiB │      0 B 
      res │ 910.2 KiB │ 910.2 KiB │      0 B │   1.4 MiB │   1.4 MiB │      0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │     6 MiB │     6 MiB │      0 B 
    asset │   2.9 MiB │   2.9 MiB │ +1.4 KiB │   2.9 MiB │   2.9 MiB │ +1.4 KiB 
    other │ 194.3 KiB │ 194.3 KiB │    -10 B │ 424.7 KiB │ 424.7 KiB │      0 B 
──────────┼───────────┼───────────┼──────────┼───────────┼───────────┼──────────
    total │  12.8 MiB │  12.8 MiB │ +2.3 KiB │  21.7 MiB │  21.7 MiB │ +2.5 KiB 

 DEX     │ old   │ new   │ diff             
─────────┼───────┼───────┼──────────────────
   files │     1 │     1 │  0               
 strings │ 43243 │ 43237 │ -6 (+40 -46)     
   types │ 14821 │ 14823 │ +2 (+37 -35)     
 classes │ 12515 │ 12517 │ +2 (+15 -13)     
 methods │ 61312 │ 61318 │ +6 (+2607 -2601) 
  fields │ 40441 │ 40445 │ +4 (+1135 -1131) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  242 │  242 │  0   
 entries │ 6033 │ 6033 │  0
APK
     compressed      │     uncompressed     │                                           
──────────┬──────────┼───────────┬──────────┤                                           
 size     │ diff     │ size      │ diff     │ path                                      
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  7.4 KiB │ +1.4 KiB │   7.2 KiB │ +1.4 KiB │ ∆ assets/dexopt/baseline.prof             
  3.9 MiB │   +931 B │   8.6 MiB │ +1.1 KiB │ ∆ classes.dex                             
 49.5 KiB │     -8 B │ 116.8 KiB │      0 B │ ∆ META-INF/MANIFEST.MF                    
    887 B │     -7 B │     755 B │     -7 B │ ∆ assets/dexopt/baseline.profm            
    270 B │     -2 B │     120 B │      0 B │ ∆ META-INF/version-control-info.textproto 
 52.8 KiB │     -2 B │ 116.9 KiB │      0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │     +2 B │   1.2 KiB │      0 B │ ∆ META-INF/CERT.RSA                       
──────────┼──────────┼───────────┼──────────┼───────────────────────────────────────────
  4.1 MiB │ +2.3 KiB │   8.9 MiB │ +2.5 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   43243 │ 43237 │ -6 (+40 -46) 
  
  + LO9/c;
  + LO9/d;
  + LR9/c;
  + LR9/d;
  + LR9/e;
  + LR9/f;
  + LS9/a;
  + LS9/b;
  + LU9/a;
  + LU9/b;
  + La7/l;
  + Lf8/F1;
  + Lm8/m;
  + Lm8/n;
  + Lp0/s1;
  + [LQ9/e;
  + [LU9/a;
  + [Lf8/Q0;
  + [Lf8/U0;
  + [Lf8/W0;
  + [Lf8/z0;
  + [Ln8/B1;
  + [Ln8/D1;
  + [Ln8/E0;
  + [Ln8/J0;
  + [Ln8/O;
  + [Ln8/Q1;
  + [Ln8/T;
  + [Ln8/X0;
  + [Ln8/f0;
  + [Ln8/l0;
  + [Ln8/o1;
  + [Ln8/v1;
  + [Ln8/w0;
  + [Lp0/D0;
  + [Lp0/s1;
  + [Lp0/z0;
  + onLinkSignUpStateUpdated
  + onLinkSignUpStateUpdated(Lcom/stripe/android/link/ui/inline/InlineSignupViewState;)V
  + ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:ae44481,r8-mode:full,version:8.3.37}
  
  - LM6/B;
  - LN9/a;
  - LN9/b;
  - LN9/c;
  - LN9/d;
  - LP9/c;
  - LP9/d;
  - LP9/e;
  - LQ9/f;
  - LS8/F;
  - LT9/a;
  - LT9/b;
  - Ln8/T1;
  - [LP9/e;
  - [LT9/a;
  - [Lf8/P0;
  - [Lf8/T0;
  - [Lf8/V0;
  - [Lf8/y0;
  - [Ln8/C1;
  - [Ln8/E1;
  - [Ln8/F0;
  - [Ln8/K0;
  - [Ln8/Q;
  - [Ln8/R1;
  - [Ln8/U;
  - [Ln8/Z0;
  - [Ln8/g0;
  - [Ln8/m0;
  - [Ln8/q1;
  - [Ln8/w1;
  - [Ln8/x0;
  - [Lp0/C0;
  - [Lp0/r1;
  - [Lp0/y0;
  - a3
  - b3
  - c3
  - d3
  - e3
  - f3
  - g3
  - i3
  - inlineSignupViewState
  - j3
  - ~~R8{backend:dex,compilation-mode:release,has-checksums:false,min-api:21,pg-map-id:a991a54,r8-mode:full,version:8.3.37}
  

TYPES:

   old   │ new   │ diff         
  ───────┼───────┼──────────────
   14821 │ 14823 │ +2 (+37 -35) 
  
  + LO9/c;
  + LO9/d;
  + LR9/c;
  + LR9/d;
  + LR9/e;
  + LR9/f;
  + LS9/a;
  + LS9/b;
  + LU9/a;
  + LU9/b;
  + La7/l;
  + Lf8/F1;
  + Lm8/m;
  + Lm8/n;
  + Lp0/s1;
  + [LQ9/e;
  + [LU9/a;
  + [Lf8/Q0;
  + [Lf8/U0;
  + [Lf8/W0;
  + [Lf8/z0;
  + [Ln8/B1;
  + [Ln8/D1;
  + [Ln8/E0;
  + [Ln8/J0;
  + [Ln8/O;
  + [Ln8/Q1;
  + [Ln8/T;
  + [Ln8/X0;
  + [Ln8/f0;
  + [Ln8/l0;
  + [Ln8/o1;
  + [Ln8/v1;
  + [Ln8/w0;
  + [Lp0/D0;
  + [Lp0/s1;
  + [Lp0/z0;
  
  - LM6/B;
  - LN9/a;
  - LN9/b;
  - LN9/c;
  - LN9/d;
  - LP9/c;
  - LP9/d;
  - LP9/e;
  - LQ9/f;
  - LS8/F;
  - LT9/a;
  - LT9/b;
  - Ln8/T1;
  - [LP9/e;
  - [LT9/a;
  - [Lf8/P0;
  - [Lf8/T0;
  - [Lf8/V0;
  - [Lf8/y0;
  - [Ln8/C1;
  - [Ln8/E1;
  - [Ln8/F0;
  - [Ln8/K0;
  - [Ln8/Q;
  - [Ln8/R1;
  - [Ln8/U;
  - [Ln8/Z0;
  - [Ln8/g0;
  - [Ln8/m0;
  - [Ln8/q1;
  - [Ln8/w1;
  - [Ln8/x0;
  - [Lp0/C0;
  - [Lp0/r1;
  - [Lp0/y0;
  

METHODS:

   old   │ new   │ diff             
  ───────┼───────┼──────────────────
   61312 │ 61318 │ +6 (+2607 -2601) 
  
  + A4.c A0() → Map
  + A4.d A0() → Map
  + A4.e A0() → Map
  + A4.f A0() → Map
  + A4.g A0() → Map
  + A5.c <init>(boolean, g1, boolean, boolean, k0)
  + A5.d <init>(boolean, g1, boolean, boolean, int)
  + A5.l <init>(String, a1, h0, f2)
  + C.i R(U0, Integer) → M0
  + C.i S(Integer, List) → M0
  + C.i u(String) → w0
  + C.j K0(int, int, int, int) → boolean
  + C.j L0(Context, e, q)
  + C.j M0(Parcel) → int
  + C.j N0(Parcel, int, int)
  + C.j Q(View, KeyEvent) → boolean
  + C.j R(n, View, Window_Callback, KeyEvent) → boolean
  + C.j S(Parcel, int)
  + C.j T(int, int) → boolean
  + C.j U(List, String) → String
  + C.j V(ArrayList, String, O, int) → String
  + C.j W(d, int, ArrayList, o) → o
  + C.j X(Object)
  + C.j Y(q1) → String
  + C.j Z() → Handler
  + C.j a0(int, int) → int
  + C.j b(n, k, int)
  + C.j b0()
  + C.j c(boolean, g1, a, int, m, boolean, e, k, int, int)
  + C.j c0(int, Rect, Rect) → boolean
  + C.j d(long, g, e, k, int)
  + C.j d0(q1) → boolean
  + C.j e(int, int) → long
  + C.j e0(JSONArray) → ArrayList
  + C.j f(k, int)
  + C.j f0(JSONObject) → Map
  + C.j g(j, boolean, c, q, k, int, int)
  + C.j g0(String, String) → int
  + C.j h(L0, g1, h0, g1, boolean, a, boolean, boolean, f, q, k, int, int)
  + C.j h0(List) → JSONArray
  + C.j i(List, Collection, k, int)
  + C.j i0(int, Rect, Rect) → int
  + C.j j(q, f, k, int, int)
  + C.j j0(Map) → JSONObject
  + C.j k(long, boolean, k, boolean, q, e, k, int)
  + C.j k0(int, Rect, Rect) → int
  + C.j l(k, int)
  + C.j l0(String) → String
  + C.j m(D) → boolean
  + C.j m0(JSONObject) → String
  + C.j n0(JSONObject, String) → String
  + C.j o(Object[], int, Object, Object) → Object[]
  + C.j o0(JSONObject) → G0
  + C.j p(int, Object[]) → Object[]
  + C.j p0(JSONObject) → J2
  + C.j q0(Map) → a
  + C.j r(int, j, Y) → int
  + C.j r0(Map) → LinkedHashSet
  + C.j s0(Map) → f
  + C.j t(int, Rect, Rect, 
...✂

@jaynewstrom-stripe jaynewstrom-stripe marked this pull request as ready for review May 23, 2024 16:47
@jaynewstrom-stripe jaynewstrom-stripe requested review from a team as code owners May 23, 2024 16:47
@jaynewstrom-stripe jaynewstrom-stripe merged commit f3b3d63 into master May 23, 2024
15 checks passed
@jaynewstrom-stripe jaynewstrom-stripe deleted the jaynewstrom/link-vert branch May 23, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants