Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the platform tag #1002

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Conversation

gracegoo-stripe
Copy link
Contributor

Reviewers

r? @vcheung-stripe
cc @stripe/developer-products

Summary

The last update causes the release step to fail while building the docker image: https://github.com/stripe/stripe-cli/actions/runs/3465880982

Not entirely sure why... but there may be a mismatch in the specific ARM version we are requesting vs. the one that we actually create. The posts below suggest omitting it:
moby/moby#42158
docker/for-linux#1170

Testing

Local building of the images seem to work on my local machine so I am unable to verify:

stripe-cli git:(gracegoo-remove-platform-tag) goreleaser release -f .goreleaser/linux.yml --rm-dist --snapshot
  • starting release...
  • loading config file                              file=.goreleaser/linux.yml
  • loading environment variables
  • getting and validating git state
    • building...                                    commit=1a174e021225b2ceec268768c52ddaedc02d7acb latest tag=v1.13.2
    • pipe skipped                                   reason=disabled during snapshot mode
  • parsing tag
  • setting defaults
  • running before hooks
    • running                                        hook=go mod download
    • running                                        hook=go generate ./...
    • took: 13s
  • snapshotting
    • building snapshot...                           version=v1.13.2-next
  • checking distribution directory
    • --rm-dist is set, cleaning it up
  • loading go mod information
  • build prerequisites
  • writing effective config file
    • writing                                        config=dist/config.yaml
  • building binaries
    • building                                       binary=dist/stripe-linux-arm_linux_arm64/stripe
    • building                                       binary=dist/stripe-linux_linux_amd64_v1/stripe
    • took: 2s
  • archives
    • creating                                       archive=dist/stripe_v1.13.2-next_linux_arm64.tar.gz
    • creating                                       archive=dist/stripe_v1.13.2-next_linux_x86_64.tar.gz
    • took: 2s
  • linux packages
    • creating                                       arch=amd64v1 file=dist/stripe_v1.13.2-next_linux_amd64.deb format=deb package=stripe
    • creating                                       arch=arm64 file=dist/stripe_v1.13.2-next_linux_arm64.deb format=deb package=stripe
    • creating                                       arch=arm64 file=dist/stripe_v1.13.2-next_linux_arm64.rpm format=rpm package=stripe
    • creating                                       arch=amd64v1 file=dist/stripe_v1.13.2-next_linux_amd64.rpm format=rpm package=stripe
  • calculating checksums
  • docker images
    • building docker image                          image=stripe/stripe-cli:latest-arm64
    • building docker image                          image=stripe/stripe-cli:latest-amd64
    • took: 3s
  • storing release metadata
    • writing                                        file=dist/artifacts.json
    • writing                                        file=dist/metadata.json
  • release succeeded after 19s

@gracegoo-stripe gracegoo-stripe requested a review from a team as a code owner November 14, 2022 23:37
@gracegoo-stripe gracegoo-stripe merged commit 24e99eb into master Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants