stripe samples: show 7 server options, not 5 #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewers
r? @
cc @stripe/developer-products
Summary
When you do "stripe samples create" it uses
promptui.Selectwhich defaults to only showing 5 options. We have 7 official SDKs, so many of the stripe samples have 7 options. Why not just show all of them? It's sometimes hard to spot that little arrow that indicates that you're able to scroll, so at first I didn't think the stripe sample had support for go or .NET, but it does:Tested locally:
Some samples have more than 7 it's true (this one has a "node-typescript" option) but let's put at least the basic versions of the 7 official libraries above the fold.