Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fixes #1158 bad invoice items URL #1157

Merged

Conversation

jcbages
Copy link
Contributor

@jcbages jcbages commented Mar 26, 2024

Reviewers

r? @tomer-stripe
cc @stripe/developer-products

Summary

Hi Stripe!

When I was using the CLI to retrieve an invoice item by ID, I tried the following:

stripe get ii_im_an_invoice_item_id

This resulted in the following error:

{
  "error": {
    "message": "Unrecognized request URL (GET: /v1/invoice_items/ii_im_an_invoice_item_id). Please see https://stripe.com/docs or we can help at https://support.stripe.com/.",
    "type": "invalid_request_error"
  }
}

Looking at the documentation for invoice items it seems the URL has a typo as it should be invoiceitems instead of invoice_items: https://docs.stripe.com/api/invoiceitems. I changed the ids.go file that maps each ID to the corresponding URL as I effectively found it was mapping to invoice_items. Now, running the command shown above effectively renders the invoice item.

Thanks! 馃帀

@jcbages jcbages requested a review from a team as a code owner March 26, 2024 04:17
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jcbages jcbages changed the title fix invoice items endpoint [Bug] Fix invoice items endpoint Mar 26, 2024
@jcbages jcbages changed the title [Bug] Fix invoice items endpoint [Bug] Fix invoice items bad endpoint Mar 26, 2024
@jcbages jcbages changed the title [Bug] Fix invoice items bad endpoint [Bug] Fix invoice items bad endpoint #1158 Mar 26, 2024
@jcbages jcbages changed the title [Bug] Fix invoice items bad endpoint #1158 [Bug] Fix #1158 invoice items bad endpoint Mar 26, 2024
@jcbages jcbages changed the title [Bug] Fix #1158 invoice items bad endpoint fixes #1158 Mar 26, 2024
@jcbages jcbages changed the title fixes #1158 [Bug] Fixes bad invoice items URL Mar 26, 2024
@jcbages jcbages changed the title [Bug] Fixes bad invoice items URL [Bug] Fixes #1158 bad invoice items URL Mar 26, 2024
Copy link
Collaborator

@tomer-stripe tomer-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tomer-stripe tomer-stripe merged commit dcb9645 into stripe:master Mar 26, 2024
4 checks passed
@jcbages jcbages mentioned this pull request Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants